Changeset 8b51009 in mainline for uspace/lib/device

Timestamp:

2025-03-28T23:37:16Z (10 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

0437dd5

Parents:

7bfe468

git-author:

Miroslav Cimerman <mc@…> (2025-03-28 23:25:57)

git-committer:

Miroslav Cimerman <mc@…> (2025-03-28 23:37:16)

Message:

hr: auto assembly, refactor

Added automatic assembly (with hrctl -A). All disks or their partitions
are scanned for HelenRAID metadata and assembly is attempted.

Main volume list is now locked with RW lock. The volume list
manipulation functions are moved into util.c.

hr_{create,destroy}_vol_struct() are implemented for better reusability
and modularity.

Volume destroy/stop (hrctl -D) now returns EBUSY if someone has still
the volume open()-ed.

Location:

uspace/lib/device

Files:

• include/hr.h (modified) (1 diff)
• include/ipc/hr.h (modified) (2 diffs)
• src/hr.c (modified) (2 diffs)

uspace/lib/device/include/hr.h

@@ -118 +118 @@
 extern void              hr_sess_destroy(hr_t *);
 extern errno_t           hr_create(hr_t *, hr_config_t *, bool);
+extern errno_t           hr_auto_assemble(size_t *);
 extern errno_t           hr_stop(const char *, long);
 extern errno_t           hr_add_hotspare(service_id_t, service_id_t);

uspace/lib/device/include/ipc/hr.h

@@ -1 +1 @@
 /*
- * Copyright (c) 2024 Miroslav Cimerman
+ * Copyright (c) 2025 Miroslav Cimerman
  * All rights reserved.
  *
@@ -41 +41 @@
         HR_CREATE = IPC_FIRST_USER_METHOD,
         HR_ASSEMBLE,
+        HR_AUTO_ASSEMBLE,
         HR_STOP,
         HR_ADD_HOTSPARE,

uspace/lib/device/src/hr.c

@@ -115 +115 @@
 }
 
+errno_t hr_auto_assemble(size_t *rassembled_cnt)
+{
+        hr_t *hr;
+        errno_t rc;
+        size_t assembled_cnt;
+
+        rc = hr_sess_init(&hr);
+        if (rc != EOK)
+                return rc;
+
+        async_exch_t *exch = async_exchange_begin(hr->sess);
+        if (exch == NULL) {
+                rc = EINVAL;
+                goto error;
+        }
+
+        aid_t req = async_send_0(exch, HR_AUTO_ASSEMBLE, NULL);
+
+        rc = async_data_read_start(exch, &assembled_cnt, sizeof(size_t));
+        if (rc != EOK) {
+                async_exchange_end(exch);
+                async_forget(req);
+                return rc;
+        }
+
+        async_exchange_end(exch);
+        async_wait_for(req, &rc);
+
+        if (rassembled_cnt != NULL)
+                *rassembled_cnt = assembled_cnt;
+error:
+        hr_sess_destroy(hr);
+        return rc;
+}
+
 static errno_t print_vol_info(size_t index, hr_vol_info_t *vol_info)
 {
@@ -218 +253 @@
         rc = async_req_2_0(exch, HR_STOP, svc_id, extent);
         async_exchange_end(exch);
-
-        if (rc != EOK)
-                goto error;
 error:
         hr_sess_destroy(hr);