Changeset 8aef01c in mainline for uspace/lib/memgfx/src

Timestamp:

2020-06-07T10:18:14Z (5 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

a65b0c8

Parents:

6301a24f

git-author:

Jiri Svoboda <jiri@…> (2020-06-07 10:11:32)

git-committer:

Jiri Svoboda <jiri@…> (2020-06-07 10:18:14)

Message:

Configurable display double-buffering

On by default (since turning off creates flicker in the absence of
front-to-back rendering). This is the quick and dirty way: display
server renders locally to a bitmap (using mem GC) and renders the
bitmap when ready.

The more sophisticated way would be to implement buffering in the
display device. That would require, however, enhancing the protocols
to communicate frame boundaries.

File:

• uspace/lib/memgfx/src/memgc.c (modified) (4 diffs)

uspace/lib/memgfx/src/memgc.c

@@ -284 +284 @@
         gfx_rect_t drect;
         gfx_coord2_t offs;
-        gfx_coord2_t dim;
         gfx_coord_t x, y;
         pixelmap_t smap;
@@ -305 +304 @@
         gfx_rect_translate(&offs, &srect, &drect);
 
-        gfx_coord2_subtract(&drect.p1, &drect.p0, &dim);
-
-        assert(mbm->rect.p0.x == 0);
-        assert(mbm->rect.p0.y == 0);
-        assert(mbm->alloc.pitch == mbm->rect.p1.x * (int)sizeof(uint32_t));
-        smap.width = mbm->rect.p1.x;
-        smap.height = mbm->rect.p1.y;
+        assert(mbm->alloc.pitch == (mbm->rect.p1.x - mbm->rect.p0.x) *
+            (int)sizeof(uint32_t));
+        smap.width = mbm->rect.p1.x - mbm->rect.p0.x;
+        smap.height = mbm->rect.p1.y - mbm->rect.p0.y;
         smap.data = mbm->alloc.pixels;
 
@@ -324 +320 @@
                 for (y = drect.p0.y; y < drect.p1.y; y++) {
                         for (x = drect.p0.x; x < drect.p1.x; x++) {
-                                pixel = pixelmap_get_pixel(&smap, x - offs.x,
-                                    y - offs.y);
+                                pixel = pixelmap_get_pixel(&smap,
+                                    x - mbm->rect.p0.x - offs.x,
+                                    y - mbm->rect.p0.y - offs.y);
                                 pixelmap_put_pixel(&dmap, x, y, pixel);
                         }
@@ -332 +329 @@
                 for (y = drect.p0.y; y < drect.p1.y; y++) {
                         for (x = drect.p0.x; x < drect.p1.x; x++) {
-                                pixel = pixelmap_get_pixel(&smap, x - offs.x,
-                                    y - offs.y);
+                                pixel = pixelmap_get_pixel(&smap,
+                                    x - mbm->rect.p0.x - offs.x,
+                                    y - mbm->rect.p0.y - offs.y);
                                 if (pixel != mbm->key_color)
                                         pixelmap_put_pixel(&dmap, x, y, pixel);