Changeset 89ea2dc in mainline for kernel/generic/src

Timestamp:

2017-12-19T17:35:28Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

d0c2beb

Parents:

7565a4b

Message:

Functions that return true/false should have bool as a return type.

Location:

kernel/generic/src

Files:

• adt/bitmap.c (modified) (1 diff)
• synch/spinlock.c (modified) (3 diffs)
• synch/workqueue.c (modified) (5 diffs)

kernel/generic/src/adt/bitmap.c

@@ -269 +269 @@
  *
  */
-int bitmap_allocate_range(bitmap_t *bitmap, size_t count, size_t base,
+bool bitmap_allocate_range(bitmap_t *bitmap, size_t count, size_t base,
     size_t prefered, size_t constraint, size_t *index)
 {

kernel/generic/src/synch/spinlock.c

@@ -153 +153 @@
  *
  */
-int spinlock_trylock(spinlock_t *lock)
+bool spinlock_trylock(spinlock_t *lock)
 {
         preemption_disable();
-        int rc = !test_and_set(&lock->val);
+        bool ret = !test_and_set(&lock->val);
         
         /*
@@ -163 +163 @@
         CS_ENTER_BARRIER();
         
-        if (!rc)
+        if (!ret)
                 preemption_enable();
         
-        return rc;
+        return ret;
 }
 
@@ -257 +257 @@
  *
  */
-int irq_spinlock_trylock(irq_spinlock_t *lock)
+bool irq_spinlock_trylock(irq_spinlock_t *lock)
 {
         ASSERT_IRQ_SPINLOCK(interrupts_disabled(), lock);
-        int rc = spinlock_trylock(&(lock->lock));
-        
-        ASSERT_IRQ_SPINLOCK((!rc) || (!lock->guard), lock);
-        return rc;
+        bool ret = spinlock_trylock(&(lock->lock));
+        
+        ASSERT_IRQ_SPINLOCK((!ret) || (!lock->guard), lock);
+        return ret;
 }
 

kernel/generic/src/synch/workqueue.c

@@ -256 +256 @@
  * workq_stop().
  */
-int workq_init(struct work_queue *workq, const char *name)
+bool workq_init(struct work_queue *workq, const char *name)
 {
         workq_preinit(workq, name);
@@ -394 +394 @@
  * See workq_enqueue_noblock() for more details.
  */
-int workq_global_enqueue_noblock(work_t *work_item, work_func_t func)
+bool workq_global_enqueue_noblock(work_t *work_item, work_func_t func)
 {
         return workq_enqueue_noblock(&g_work_queue, work_item, func);
@@ -403 +403 @@
  * See workq_enqueue() for more details.
  */
-int workq_global_enqueue(work_t *work_item, work_func_t func)
+bool workq_global_enqueue(work_t *work_item, work_func_t func)
 {
         return workq_enqueue(&g_work_queue, work_item, func);
@@ -426 +426 @@
  * @return true  Otherwise. func() will be invoked in a separate thread.
  */
-int workq_enqueue_noblock(struct work_queue *workq, work_t *work_item, 
+bool workq_enqueue_noblock(struct work_queue *workq, work_t *work_item, 
         work_func_t func)
 {
@@ -446 +446 @@
  * @return true  Otherwise. func() will be invoked in a separate thread.
  */
-int workq_enqueue(struct work_queue *workq, work_t *work_item, work_func_t func)
+bool workq_enqueue(struct work_queue *workq, work_t *work_item, work_func_t func)
 {
         return _workq_enqueue(workq, work_item, func, true);