Changeset 879585a3 in mainline for kernel/generic/include/mm

Timestamp:

2007-03-31T22:22:50Z (18 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

31d8e10

Parents:

563c2dd

Message:

Simplify synchronization in as_switch().
The function was oversynchronized, which
was causing deadlocks on the address
space mutex.

Now, address spaces can only be switched
when the asidlock is held. This also protects
stealing of ASIDs. No other synchronization
is necessary.

File:

• kernel/generic/include/mm/as.h (modified) (5 diffs)

kernel/generic/include/mm/as.h

@@ -90 +90 @@
                 /** Protected by asidlock. */
                 link_t inactive_as_with_asid_link;
+                /**
+                 * Number of processors on wich is this address space active.
+                 * Protected by asidlock.
+                 */
+                count_t cpu_refcount;
+                /**
+                 * Address space identifier.
+                 * Constant on architectures that do not support ASIDs.
+                 * Protected by asidlock.  
+                 */
+                asid_t asid;
                 
                 mutex_t lock;
@@ -96 +107 @@
                 count_t refcount;
                 
-                /** Number of processors on wich is this address space active. */
-                count_t cpu_refcount;
-                
                 /** B+tree of address space areas. */
                 btree_t as_area_btree;
-                
-                /**
-                 *  Address space identifier.
-                 *  Constant on architectures that do not support ASIDs.
-                 */
-                asid_t asid;
                 
                 /** Non-generic content. */
@@ -134 +136 @@
         /** Protected by asidlock. */
         link_t inactive_as_with_asid_link;
+        /**
+         * Number of processors on wich is this address space active.
+         * Protected by asidlock.
+         */
+        count_t cpu_refcount;
+        /**
+         * Address space identifier.
+         * Constant on architectures that do not support ASIDs.
+         * Protected by asidlock.
+         */
+        asid_t asid;
 
         mutex_t lock;
@@ -140 +153 @@
         count_t refcount;
 
-        /** Number of processors on wich is this address space active. */
-        count_t cpu_refcount;
-
         /** B+tree of address space areas. */
         btree_t as_area_btree;
-        
-        /**
-         *  Address space identifier.
-         *  Constant on architectures that do not support ASIDs.
-         */
-        asid_t asid;
         
         /** Non-generic content. */
@@ -250 +254 @@
 #endif
 
-SPINLOCK_EXTERN(inactive_as_with_asid_lock);
 extern link_t inactive_as_with_asid_head;