Changeset 86ffa27f in mainline for uspace/srv/devman

Timestamp:

2011-08-07T11:21:44Z (14 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

cc574511

Parents:

15f3c3f (diff), e8067c0 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge mainline changes.

Location:

uspace/srv/devman

Files:

• devman.c (modified) (2 diffs)
• util.c (modified) (2 diffs)
• util.h (modified) (1 diff)

uspace/srv/devman/devman.c

@@ -270 +270 @@
         }
         
-        ssize_t read_bytes = safe_read(fd, buf, len);
+        ssize_t read_bytes = read_all(fd, buf, len);
         if (read_bytes <= 0) {
-                log_msg(LVL_ERROR, "Unable to read file '%s'.", conf_path);
+                log_msg(LVL_ERROR, "Unable to read file '%s' (%zd).", conf_path,
+                    read_bytes);
                 goto cleanup;
         }
@@ -421 +422 @@
         }
         
-        insert_fun_node(tree, fun, clone_string(""), NULL);
+        insert_fun_node(tree, fun, str_dup(""), NULL);
         match_id_t *id = create_match_id();
-        id->id = clone_string("root");
+        id->id = str_dup("root");
         id->score = 100;
         add_match_id(&fun->match_ids, id);

uspace/srv/devman/util.c

@@ -91 +91 @@
 }
 
-char *clone_string(const char *s)
-{
-        size_t size = str_size(s) + 1;
-        char *str;
-        
-        str = (char *) malloc(size);
-        if (str != NULL)
-                str_cpy(str, size, s);
-        return str;
-}
-
 void replace_char(char *str, char orig, char repl)
 {
@@ -111 +100 @@
 }
 
-ssize_t safe_read(int fd, void *buffer, size_t size)
-{
-        if (size == 0) {
-                return 0;
-        }
-
-        uint8_t *buf_ptr = (uint8_t *) buffer;
-
-        size_t total_read = 0;
-        while (total_read < size) {
-                ssize_t bytes_read = read(fd, buf_ptr, size - total_read);
-                if (bytes_read < 0) {
-                        /* Error. */
-                        return bytes_read;
-                } else if (bytes_read == 0) {
-                        /* Possibly end of file. */
-                        break;
-                } else {
-                        /* Read at least something. */
-                        buf_ptr += bytes_read;
-                        total_read += bytes_read;
-                }
-        }
-
-        return (ssize_t) total_read;
-}
-
 /** @}
  */

uspace/srv/devman/util.h

@@ -44 +44 @@
 extern size_t get_nonspace_len(const char *);
 extern void free_not_null(const void *);
-extern char *clone_string(const char *);
 extern void replace_char(char *, char, char);
-
-extern ssize_t safe_read(int, void *, size_t);
 
 #endif