Changeset 84439d7 in mainline for uspace/srv/devman

Timestamp:

2010-12-05T09:34:46Z (15 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

75732da

Parents:

56b962d (diff), 35537a7 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge with development/

Location:

uspace/srv/devman

Files:

• devman.c (modified) (2 diffs)
• main.c (modified) (5 diffs)
• match.c (modified) (2 diffs)

uspace/srv/devman/devman.c

@@ -651 +651 @@
         
         /* Send the device to the driver. */
-        aid_t req = async_send_1(phone, DRIVER_ADD_DEVICE, node->handle,
-            &answer);
+        devman_handle_t parent_handle;
+        if (node->parent) {
+                parent_handle = node->parent->handle;
+        } else {
+                parent_handle = 0;
+        }
+        aid_t req = async_send_2(phone, DRIVER_ADD_DEVICE, node->handle,
+            parent_handle, &answer);
         
         /* Send the device's name to the driver. */
@@ -1022 +1028 @@
         
         size_t idx = get_new_class_dev_idx(cl);
-        asprintf(&dev_name, "%s%d", base_name, idx);
+        asprintf(&dev_name, "%s%zu", base_name, idx);
         
         return dev_name;

uspace/srv/devman/main.c

@@ -36 +36 @@
  */
 
+#include <inttypes.h>
 #include <assert.h>
 #include <ipc/services.h>
@@ -405 +406 @@
                         break;
                 default:
-                        if (!(callid & IPC_CALLID_NOTIFICATION))
-                                ipc_answer_0(callid, ENOENT);
+                        ipc_answer_0(callid, ENOENT);
                 }
         }
@@ -418 +418 @@
         node_t *dev = find_dev_node(&device_tree, handle);
         if (dev == NULL) {
-                printf(NAME ": devman_forward error - no device with handle %x "
-                    "was found.\n", handle);
+                printf(NAME ": devman_forward error - no device with handle %" PRIun
+                    " was found.\n", handle);
                 ipc_answer_0(iid, ENOENT);
                 return;
@@ -435 +435 @@
         
         if (driver == NULL) {
-                printf(NAME ": devman_forward error - the device is not in "
-                    "usable state.\n", handle);
+                printf(NAME ": devman_forward error - the device is not in %" PRIun
+                    " usable state.\n", handle);
                 ipc_answer_0(iid, ENOENT);
                 return;
@@ -450 +450 @@
                 printf(NAME ": devman_forward: cound not forward to driver %s ",
                     driver->name);
-                printf("the driver's phone is %x).\n", driver->phone);
+                printf("the driver's phone is %" PRIun ").\n", driver->phone);
                 ipc_answer_0(iid, EINVAL);
                 return;

uspace/srv/devman/match.c

@@ -35 +35 @@
 #include "devman.h"
 
+/** Compute compound score of driver and device.
+ *
+ * @param driver Match id of the driver.
+ * @param device Match id of the device.
+ * @return Compound score.
+ * @retval 0 No match at all.
+ */
+static int compute_match_score(match_id_t *driver, match_id_t *device)
+{
+        if (str_cmp(driver->id, device->id) == 0) {
+                /*
+                 * The strings matches, return their score multiplied.
+                 */
+                return driver->score * device->score;
+        } else {
+                /*
+                 * Different strings, return zero.
+                 */
+                return 0;
+        }
+}
+
 int get_match_score(driver_t *drv, node_t *dev)
 {
@@ -44 +66 @@
         
         /*
-         * Find first matching pair.
+         * Go through all pairs, return the highest score obtainetd.
          */
+        int highest_score = 0;
+        
         link_t *drv_link = drv->match_ids.ids.next;
         while (drv_link != drv_head) {
-                link_t *dev_link = dev->match_ids.ids.next;
+                link_t *dev_link = dev_head->next;
                 while (dev_link != dev_head) {
                         match_id_t *drv_id = list_get_instance(drv_link, match_id_t, link);
                         match_id_t *dev_id = list_get_instance(dev_link, match_id_t, link);
-
-                        if (str_cmp(drv_id->id, dev_id->id) == 0) {
-                                /*
-                                 * We found a match.
-                                 * Return the score of the match.
-                                 */
-                                return drv_id->score * dev_id->score;
+                        
+                        int score = compute_match_score(drv_id, dev_id);
+                        if (score > highest_score) {
+                                highest_score = score;
                         }
 
                         dev_link = dev_link->next;
                 }
+                
                 drv_link = drv_link->next;
         }
         
-        return 0;
+        return highest_score;
 }