Changeset 80d2bdb in mainline for arch/mips32

Timestamp:

2005-12-15T16:10:19Z (20 years ago)

Author:

Ondrej Palkovsky <ondrap@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b4cad8b2

Parents:

7dd2561

Message:

We are now almost -Wall clean.

• redefined atomic_t
• deleted many, many unused variables
• some minor code cleanups found using compiler warning.

Location:

arch/mips32

Files:

• include/atomic.h (modified) (3 diffs)
• src/drivers/arc.c (modified) (2 diffs)
• src/drivers/serial.c (modified) (1 diff)

arch/mips32/include/atomic.h

@@ -42 +42 @@
 
 
-typedef volatile __u32 atomic_t;
+typedef struct { volatile __u32 count; } atomic_t;
 
 /* Atomic addition of immediate value.
@@ -63 +63 @@
                 "       beq %0, %4, 1b\n"       /* if the atomic operation failed, try again */
                 /*      nop     */              /* nop is inserted automatically by compiler */
-                : "=r" (tmp), "=m" (*val), "=r" (v)
+                : "=r" (tmp), "=m" (val->count), "=r" (v)
                 : "i" (i), "i" (0)
                 );
@@ -70 +70 @@
 }
 
+/* Reads/writes are atomic on mips for 4-bytes */
+
+static inline void atomic_set(atomic_t *val, __u32 i)
+{
+        val->count = i;
+}
+
+static inline __u32 atomic_get(atomic_t *val)
+{
+        return val->count;
+}
 
 #endif

arch/mips32/src/drivers/arc.c

@@ -189 +189 @@
         arc_putchar('C');
         arc_putchar('\n');
+
+        return 0;
 }
 
@@ -287 +289 @@
         __address base;
         size_t basesize;
-        unsigned int i,j;
 
         desc = arc_entry->getmemorydescriptor(NULL);

arch/mips32/src/drivers/serial.c

@@ -39 +39 @@
 static void serial_write(chardev_t *d, const char ch)
 {
-        int i;
         serial_t *sd = (serial_t *)d->data;