Changeset 80d2bdb in mainline for arch/ia32/include/atomic.h

Timestamp:

2005-12-15T16:10:19Z (20 years ago)

Author:

Ondrej Palkovsky <ondrap@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b4cad8b2

Parents:

7dd2561

Message:

We are now almost -Wall clean.

• redefined atomic_t
• deleted many, many unused variables
• some minor code cleanups found using compiler warning.

File:

• arch/ia32/include/atomic.h (modified) (5 diffs)

arch/ia32/include/atomic.h

@@ -32 +32 @@
 #include <arch/types.h>
 
-typedef volatile __u32 atomic_t;
+typedef struct { volatile __u32 count; } atomic_t;
+
+static inline void atomic_set(atomic_t *val, __u32 i)
+{
+        val->count = i;
+}
+
+static inline __u32 atomic_get(atomic_t *val)
+{
+        return val->count;
+}
 
 static inline void atomic_inc(atomic_t *val) {
 #ifdef CONFIG_SMP
-        __asm__ volatile ("lock incl %0\n" : "=m" (*val));
+        __asm__ volatile ("lock incl %0\n" : "=m" (val->count));
 #else
-        __asm__ volatile ("incl %0\n" : "=m" (*val));
+        __asm__ volatile ("incl %0\n" : "=m" (val->count));
 #endif /* CONFIG_SMP */
 }
@@ -44 +54 @@
 static inline void atomic_dec(atomic_t *val) {
 #ifdef CONFIG_SMP
-        __asm__ volatile ("lock decl %0\n" : "=m" (*val));
+        __asm__ volatile ("lock decl %0\n" : "=m" (val->count));
 #else
-        __asm__ volatile ("decl %0\n" : "=m" (*val));
+        __asm__ volatile ("decl %0\n" : "=m" (val->count));
 #endif /* CONFIG_SMP */
 }
@@ -56 +66 @@
                 "movl $1, %0\n"
                 "lock xaddl %0, %1\n"
-                : "=r"(r), "=m" (*val)
+                : "=r"(r), "=m" (val->count)
         );
         return r;
@@ -77 +87 @@
 #define atomic_dec_post(val) (atomic_dec_pre(val)-1)
 
-static inline int test_and_set(volatile int *val) {
+static inline int test_and_set(atomic_t *val) {
         int v;
         
@@ -83 +93 @@
                 "movl $1, %0\n"
                 "xchgl %0, %1\n"
-                : "=r" (v),"=m" (*val)
+                : "=r" (v),"=m" (val->count)
         );