Changeset 7cce333 in mainline for uspace/lib

Timestamp:

2019-08-07T10:22:06Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

5353f50

Parents:

a097c50

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-11-10 21:19:03)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-07 10:22:06)

Message:

sysman: Refined semantics of IPC_FLAG_AUTOSTART

IPC_FLAG_AUTOSTART_ is for internal use in brokers (added underscore).
IPC_AUTOSTART is a flag macro (not a _single_ flag) to be used by clients.

Conflicts:

uspace/lib/c/generic/loc.c
uspace/lib/gui/window.c
uspace/srv/vfs/vfs_ops.c

Location:

uspace/lib

Files:

• c/generic/loc.c (modified) (1 diff)
• c/include/ipc/common.h (modified) (1 diff)
• gui/window.c (modified) (1 diff)

uspace/lib/c/generic/loc.c

@@ -329 +329 @@
         async_exch_t *exch;
 
-        if ((flags & IPC_FLAG_BLOCKING) || flags & IPC_FLAG_AUTOSTART)
+        if ((flags & IPC_FLAG_BLOCKING))
                 exch = loc_exchange_begin_blocking(INTERFACE_LOC_CONSUMER);
         else {

uspace/lib/c/include/ipc/common.h

@@ -43 +43 @@
 
 #define IPC_FLAG_BLOCKING   0x01
-// TODO autostart flag may be united with blocking, this should be later made
-//      implicit, documented or refactor pairs of xxx and xxx_blocking methods
-#define IPC_FLAG_AUTOSTART  0x02
+
+/**
+ * IPC_FLAG_AUTOSTART_ is for use in brokers only. In clinet code use
+ * IPC_AUTOSTART that includes implies blocking behavior. */
+#define IPC_FLAG_AUTOSTART_  0x02
+
+/**
+ * Similar to blocking IPC_FLAG_BLOCKING behavior, broker will attempt to
+ * start the server.
+ */
+#define IPC_AUTOSTART (IPC_FLAG_BLOCKING | IPC_FLAG_AUTOSTART_)
 
 typedef ipc_data_t ipc_call_t;

uspace/lib/gui/window.c

@@ -615 +615 @@
         win->focus = NULL;
         win->surface = NULL;
-
-        unsigned int ipc_flags = IPC_FLAG_AUTOSTART;
+        
+        unsigned int ipc_flags = IPC_AUTOSTART;
         service_id_t reg_dsid;
         errno_t rc = loc_service_get_id(winreg, &reg_dsid, ipc_flags);