Changeset 79ae36dd in mainline for uspace/srv/devman

Timestamp:

2011-06-08T19:01:55Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0eff68e

Parents:

764d71e

Message:

new async framework with integrated exchange tracking

• strict isolation between low-level IPC and high-level async framework with integrated exchange tracking
  • each IPC connection is represented by an async_sess_t structure
  • each IPC exchange is represented by an async_exch_t structure
  • exchange management is either based on atomic messages (EXCHANGE_ATOMIC), locking (EXCHANGE_SERIALIZE) or connection cloning (EXCHANGE_CLONE)
• async_obsolete: temporary compatibility layer to keep old async clients working (several pieces of code are currently broken, but only non-essential functionality)
• IPC_M_PHONE_HANGUP is now method no. 0 (for elegant boolean evaluation)
• IPC_M_DEBUG_ALL has been renamed to IPC_M_DEBUG
• IPC_M_PING has been removed (VFS protocol now has VFS_IN_PING)
• console routines in libc have been rewritten for better abstraction
• additional use for libc-private header files (FILE structure opaque to the client)
• various cstyle changes (typos, indentation, missing externs in header files, improved comments, etc.)

Location:

uspace/srv/devman

Files:

• devman.c (modified) (9 diffs)
• devman.h (modified) (4 diffs)
• main.c (modified) (11 diffs)

uspace/srv/devman/devman.c

@@ -564 +564 @@
         dev_node_t *dev;
         link_t *link;
-        int phone;
 
         log_msg(LVL_DEBUG, "pass_devices_to_driver(driver=\"%s\")",
@@ -570 +569 @@
 
         fibril_mutex_lock(&driver->driver_mutex);
-
-        phone = async_connect_me_to(driver->phone, DRIVER_DEVMAN, 0, 0);
-
-        if (phone < 0) {
+        
+        async_exch_t *exch = async_exchange_begin(driver->sess);
+        async_sess_t *sess = async_connect_me_to(EXCHANGE_SERIALIZE, exch,
+            DRIVER_DEVMAN, 0, 0);
+        async_exchange_end(exch);
+
+        if (!sess) {
                 fibril_mutex_unlock(&driver->driver_mutex);
                 return;
@@ -602 +604 @@
                 fibril_mutex_unlock(&driver->driver_mutex);
 
-                add_device(phone, driver, dev, tree);
+                add_device(sess, driver, dev, tree);
 
                 /*
@@ -623 +625 @@
         }
 
-        async_hangup(phone);
+        async_hangup(sess);
 
         /*
@@ -673 +675 @@
         list_initialize(&drv->devices);
         fibril_mutex_initialize(&drv->driver_mutex);
-        drv->phone = -1;
+        drv->sess = NULL;
 }
 
@@ -737 +739 @@
  * @param node          The device's node in the device tree.
  */
-void add_device(int phone, driver_t *drv, dev_node_t *dev, dev_tree_t *tree)
+void add_device(async_sess_t *sess, driver_t *drv, dev_node_t *dev,
+    dev_tree_t *tree)
 {
         /*
@@ -746 +749 @@
             drv->name, dev->pfun->name);
         
-        sysarg_t rc;
-        ipc_call_t answer;
-        
         /* Send the device to the driver. */
         devman_handle_t parent_handle;
@@ -756 +756 @@
                 parent_handle = 0;
         }
-
-        aid_t req = async_send_2(phone, DRIVER_ADD_DEVICE, dev->handle,
+        
+        async_exch_t *exch = async_exchange_begin(sess);
+        
+        ipc_call_t answer;
+        aid_t req = async_send_2(exch, DRIVER_ADD_DEVICE, dev->handle,
             parent_handle, &answer);
         
-        /* Send the device's name to the driver. */
-        rc = async_data_write_start(phone, dev->pfun->name,
+        /* Send the device name to the driver. */
+        sysarg_t rc = async_data_write_start(exch, dev->pfun->name,
             str_size(dev->pfun->name) + 1);
+        
+        async_exchange_end(exch);
+        
         if (rc != EOK) {
                 /* TODO handle error */
@@ -823 +829 @@
         if (is_running) {
                 /* Notify the driver about the new device. */
-                int phone = async_connect_me_to(drv->phone, DRIVER_DEVMAN, 0, 0);
-                if (phone >= 0) {
-                        add_device(phone, drv, dev, tree);
-                        async_hangup(phone);
+                async_exch_t *exch = async_exchange_begin(drv->sess);
+                async_sess_t *sess = async_connect_me_to(EXCHANGE_SERIALIZE, exch,
+                    DRIVER_DEVMAN, 0, 0);
+                async_exchange_end(exch);
+                
+                if (sess) {
+                        add_device(sess, drv, dev, tree);
+                        async_hangup(sess);
                 }
         }

uspace/srv/devman/devman.h

@@ -44 +44 @@
 #include <fibril_synch.h>
 #include <atomic.h>
+#include <async.h>
 
 #include "util.h"
@@ -87 +88 @@
         int state;
         
-        /** Phone asociated with this driver. */
-        int phone;
+        /** Session asociated with this driver. */
+        async_sess_t *sess;
         /** Name of the device driver. */
         char *name;
@@ -99 +100 @@
         
         /**
-         * Fibril mutex for this driver - driver state, list of devices, phone.
+         * Fibril mutex for this driver - driver state, list of devices, session.
          */
         fibril_mutex_t driver_mutex;
@@ -312 +313 @@
 extern void add_driver(driver_list_t *, driver_t *);
 extern void attach_driver(dev_node_t *, driver_t *);
-extern void add_device(int, driver_t *, dev_node_t *, dev_tree_t *);
+extern void add_device(async_sess_t *, driver_t *, dev_node_t *, dev_tree_t *);
 extern bool start_driver(driver_t *);
 

uspace/srv/devman/main.c

@@ -39 +39 @@
 #include <assert.h>
 #include <ipc/services.h>
-#include <ipc/ns.h>
+#include <ns.h>
 #include <async.h>
 #include <stdio.h>
@@ -108 +108 @@
         fibril_mutex_lock(&driver->driver_mutex);
         
-        if (driver->phone >= 0) {
+        if (driver->sess) {
                 /* We already have a connection to the driver. */
                 log_msg(LVL_ERROR, "Driver '%s' already started.\n",
@@ -128 +128 @@
                 break;
         case DRIVER_RUNNING:
-                /* Should not happen since we do not have a connected phone */
+                /* Should not happen since we do not have a connected session */
                 assert(false);
         }
@@ -135 +135 @@
         log_msg(LVL_DEBUG, "Creating connection to the `%s' driver.",
             driver->name);
-        ipc_call_t call;
-        ipc_callid_t callid = async_get_call(&call);
-        if (IPC_GET_IMETHOD(call) != IPC_M_CONNECT_TO_ME) {
+        driver->sess = async_callback_receive(EXCHANGE_SERIALIZE);
+        if (!driver->sess) {
                 fibril_mutex_unlock(&driver->driver_mutex);
-                async_answer_0(callid, ENOTSUP);
                 async_answer_0(iid, ENOTSUP);
                 return NULL;
         }
         
-        /* Remember driver's phone. */
-        driver->phone = IPC_GET_ARG5(call);
-        
         fibril_mutex_unlock(&driver->driver_mutex);
         
-        log_msg(LVL_NOTE, 
+        log_msg(LVL_NOTE,
             "The `%s' driver was successfully registered as running.",
             driver->name);
         
-        async_answer_0(callid, EOK);
         async_answer_0(iid, EOK);
         
@@ -434 +428 @@
         fibril_add_ready(fid);
         
-        ipc_callid_t callid;
-        ipc_call_t call;
-        bool cont = true;
-        while (cont) {
-                callid = async_get_call(&call);
+        while (true) {
+                ipc_call_t call;
+                ipc_callid_t callid = async_get_call(&call);
+                
+                if (!IPC_GET_IMETHOD(call))
+                        break;
                 
                 switch (IPC_GET_IMETHOD(call)) {
-                case IPC_M_PHONE_HUNGUP:
-                        cont = false;
-                        continue;
                 case DEVMAN_ADD_FUNCTION:
                         devman_add_function(callid, &call);
@@ -559 +551 @@
         async_answer_0(iid, EOK);
         
-        bool cont = true;
-        while (cont) {
+        while (true) {
                 ipc_call_t call;
                 ipc_callid_t callid = async_get_call(&call);
                 
+                if (!IPC_GET_IMETHOD(call))
+                        break;
+                
                 switch (IPC_GET_IMETHOD(call)) {
-                case IPC_M_PHONE_HUNGUP:
-                        cont = false;
-                        continue;
                 case DEVMAN_DEVICE_GET_HANDLE:
                         devman_function_get_handle(callid, &call);
@@ -635 +626 @@
         if (driver == NULL) {
                 log_msg(LVL_ERROR, "IPC forwarding refused - " \
-                    "the device %" PRIun "(%s) is not in usable state.",
-                    handle, dev->pfun->pathname);
+                    "the device %" PRIun " is not in usable state.", handle);
                 async_answer_0(iid, ENOENT);
                 return;
@@ -647 +637 @@
                 method = DRIVER_CLIENT;
         
-        if (driver->phone < 0) {
-                log_msg(LVL_ERROR, 
-                    "Could not forward to driver `%s' (phone is %d).",
-                    driver->name, (int) driver->phone);
+        if (!driver->sess) {
+                log_msg(LVL_ERROR,
+                    "Could not forward to driver `%s'.", driver->name);
                 async_answer_0(iid, EINVAL);
                 return;
@@ -664 +653 @@
                     dev->pfun->pathname, driver->name);
         }
-
-        async_forward_fast(iid, driver->phone, method, fwd_h, 0, IPC_FF_NONE);
+        
+        async_exch_t *exch = async_exchange_begin(driver->sess);
+        async_forward_fast(iid, exch, method, fwd_h, 0, IPC_FF_NONE);
+        async_exchange_end(exch);
 }
 
@@ -687 +678 @@
         dev = fun->dev;
         
-        if (dev->state != DEVICE_USABLE || dev->drv->phone < 0) {
+        if ((dev->state != DEVICE_USABLE) || (!dev->drv->sess)) {
                 async_answer_0(iid, EINVAL);
                 return;
         }
         
-        async_forward_fast(iid, dev->drv->phone, DRIVER_CLIENT, fun->handle, 0,
+        async_exch_t *exch = async_exchange_begin(dev->drv->sess);
+        async_forward_fast(iid, exch, DRIVER_CLIENT, fun->handle, 0,
             IPC_FF_NONE);
-        log_msg(LVL_DEBUG, 
+        async_exchange_end(exch);
+        
+        log_msg(LVL_DEBUG,
             "Forwarding devmapper request for `%s' function to driver `%s'.",
             fun->pathname, dev->drv->name);
@@ -786 +780 @@
 
         printf(NAME ": Accepting connections.\n");
+        task_retval(0);
         async_manager();