Changeset 79ae36dd in mainline for uspace/app/taskdump/elf_core.c

Timestamp:

2011-06-08T19:01:55Z (14 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0eff68e

Parents:

764d71e

Message:

new async framework with integrated exchange tracking

• strict isolation between low-level IPC and high-level async framework with integrated exchange tracking
  • each IPC connection is represented by an async_sess_t structure
  • each IPC exchange is represented by an async_exch_t structure
  • exchange management is either based on atomic messages (EXCHANGE_ATOMIC), locking (EXCHANGE_SERIALIZE) or connection cloning (EXCHANGE_CLONE)
• async_obsolete: temporary compatibility layer to keep old async clients working (several pieces of code are currently broken, but only non-essential functionality)
• IPC_M_PHONE_HANGUP is now method no. 0 (for elegant boolean evaluation)
• IPC_M_DEBUG_ALL has been renamed to IPC_M_DEBUG
• IPC_M_PING has been removed (VFS protocol now has VFS_IN_PING)
• console routines in libc have been rewritten for better abstraction
• additional use for libc-private header files (FILE structure opaque to the client)
• various cstyle changes (typos, indentation, missing externs in header files, improved comments, etc.)

File:

• uspace/app/taskdump/elf_core.c (modified) (5 diffs)

uspace/app/taskdump/elf_core.c

@@ -62 +62 @@
 #include "include/elf_core.h"
 
-static off64_t align_foff_up(off64_t foff, uintptr_t vaddr, size_t page_size);
-static int write_all(int fd, void *data, size_t len);
-static int write_mem_area(int fd, as_area_info_t *area, int phoneid);
+static off64_t align_foff_up(off64_t, uintptr_t, size_t);
+static int write_all(int, void *, size_t);
+static int write_mem_area(int, as_area_info_t *, async_sess_t *);
 
 #define BUFFER_SIZE 0x1000
@@ -71 +71 @@
 /** Save ELF core file.
  *
- * @param file_name     Name of file to save to.
- * @param ainfo         Array of @a n memory area info structures.
- * @param n             Number of memory areas.
- * @param phoneid       Debugging phone.
- *
- * @return              EOK on sucess, ENOENT if file cannot be created,
- *                      ENOMEM on out of memory, EIO on write error.
- */
-int elf_core_save(const char *file_name, as_area_info_t *ainfo, unsigned int n, int phoneid)
+ * @param file_name Name of file to save to.
+ * @param ainfo     Array of @a n memory area info structures.
+ * @param n         Number of memory areas.
+ * @param sess      Debugging session.
+ *
+ * @return EOK on sucess.
+ * @return ENOENT if file cannot be created.
+ * @return ENOMEM on out of memory.
+ * @return EIO on write error.
+ *
+ */
+int elf_core_save(const char *file_name, as_area_info_t *ainfo, unsigned int n,
+    async_sess_t *sess)
 {
         elf_header_t elf_hdr;
@@ -189 +193 @@
                         return EIO;
                 }
-                if (write_mem_area(fd, &ainfo[i], phoneid) != EOK) {
+                if (write_mem_area(fd, &ainfo[i], sess) != EOK) {
                         printf("Failed writing memory data.\n");
                         free(p_hdr);
@@ -215 +219 @@
 /** Write memory area from application to core file.
  *
- * @param fd            File to write to.
- * @param area          Memory area info structure.
- * @param phoneid       Debugging phone.
- *
- * @return              EOK on success, EIO on failure.
- */
-static int write_mem_area(int fd, as_area_info_t *area, int phoneid)
+ * @param fd   File to write to.
+ * @param area Memory area info structure.
+ * @param sess Debugging session.
+ *
+ * @return EOK on success, EIO on failure.
+ *
+ */
+static int write_mem_area(int fd, as_area_info_t *area, async_sess_t *sess)
 {
         size_t to_copy;
@@ -233 +238 @@
         while (total < area->size) {
                 to_copy = min(area->size - total, BUFFER_SIZE);
-                rc = udebug_mem_read(phoneid, buffer, addr, to_copy);
+                rc = udebug_mem_read(sess, buffer, addr, to_copy);
                 if (rc < 0) {
                         printf("Failed reading task memory.\n");