Changeset 78f0422c in mainline for uspace/lib/c

Timestamp:

2023-10-22T17:27:09Z (21 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

133461c

Parents:

71b4444 (diff), dfb16c4 (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Merge C/C++ changes needed to build with newer GCC

Location:

uspace/lib/c

Files:

• generic/rtld/symbol.c (modified) (1 diff)
• generic/thread/fibril_synch.c (modified) (1 diff)
• include/adt/list.h (modified) (1 diff)
• include/fibril_synch.h (modified) (1 diff)
• test/string.c (modified) (1 diff)

uspace/lib/c/generic/rtld/symbol.c

@@ -135 +135 @@
         modules_untag(start->rtld);
 
-        /* Insert root (the program) into the queue and tag it */
+        /*
+         * Insert root (the program) into the queue and tag it.
+         *
+         * We disable the dangling-pointer warning because the compiler incorrectly
+         * assumes that we leak local address (queue) to a parent scope (to start
+         * argument). However, we always empty the list so the pointer cannot
+         * actually escape. Probably the compiler can never statically analyze that
+         * correctly.
+         */
         list_initialize(&queue);
         start->bfs_tag = true;
+#pragma GCC diagnostic push
+#if defined(__GNUC__) && (__GNUC__ >= 12)
+#pragma GCC diagnostic ignored "-Wdangling-pointer"
+#endif
         list_append(&start->queue_link, &queue);
+#pragma GCC diagnostic pop
 
         /* If the symbol is found, it will be stored in 'sym' */

uspace/lib/c/generic/thread/fibril_synch.c

@@ -160 +160 @@
 {
         check_fibril_for_deadlock(oi, fibril_self());
-}
-
-void fibril_mutex_initialize(fibril_mutex_t *fm)
-{
-        fm->oi.owned_by = NULL;
-        fm->counter = 1;
-        list_initialize(&fm->waiters);
 }
 

uspace/lib/c/include/adt/list.h

@@ -183 +183 @@
  *
  */
-_NO_TRACE static inline void list_initialize(list_t *list)
+_NO_TRACE static inline __CONSTEXPR void list_initialize(list_t *list)
 {
         list->head.prev = &list->head;

uspace/lib/c/include/fibril_synch.h

@@ -153 +153 @@
 extern void __fibril_synch_fini(void);
 
-extern void fibril_mutex_initialize(fibril_mutex_t *);
+/** Initialize fibril mutex.
+ *
+ * Kept as in-line to allow constexpr marker for C++ library where this
+ * is used by C++ mutex type (list initialization are two assignments
+ * so it is actually reasonable to have this inlined).
+ */
+static inline __CONSTEXPR void fibril_mutex_initialize(fibril_mutex_t *fm)
+{
+        fm->oi.owned_by = NULL;
+        fm->counter = 1;
+        list_initialize(&fm->waiters);
+}
+
 extern void fibril_mutex_lock(fibril_mutex_t *);
 extern bool fibril_mutex_trylock(fibril_mutex_t *);

uspace/lib/c/test/string.c

@@ -799 +799 @@
 PCUT_TEST(strndup_nonempty_short)
 {
+#pragma GCC diagnostic push
+        // Intentionally checking it works with _longer_ size than actual
+#if defined(__GNUC__) && (__GNUC__ >= 11)
+#pragma GCC diagnostic ignored "-Wstringop-overread"
+#endif
         char *d = strndup("abc", 5);
+#pragma GCC diagnostic pop
         PCUT_ASSERT_NOT_NULL(d);
         PCUT_ASSERT_TRUE(d[0] == 'a');