Changeset 774e6d1a in mainline for uspace/srv/net/tl/tcp

Timestamp:

2011-01-09T23:24:53Z (15 years ago)

Author:

martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4b86dac

Parents:

3c106e88

Message:

partial networking stack overhaul

• a lot of coding style changes (comments, indentation, etc.)
• convert several ints to unsigned ints or size_t values
• streamline many of the IPC-related macros (they no longer dereference the call structure by themselves)
• get rid of netif_interface.h (containing only aliases for remote functions and not serving any purpose)
• rename netif_local.{c|h} to netif_skel.{c|h} (it is really just a skeleton)
• drop the "_remote" and "_standalone" suffixes from most of the netif_ functions (they do not serve any purpose anymore)
• implement netif_client_connection() as a common framework function for all netif modules
  • update the lo module accordingly
• ip module now reports the default gateway to the user whenever it is being set

Location:

uspace/srv/net/tl/tcp

Files:

• tcp.c (modified) (5 diffs)
• tcp_module.c (modified) (1 diff)
• tcp_module.h (modified) (1 diff)

uspace/srv/net/tl/tcp/tcp.c

@@ -1262 +1262 @@
 int
 tcp_message_standalone(ipc_callid_t callid, ipc_call_t *call,
-    ipc_call_t *answer, int *answer_count)
+    ipc_call_t *answer, size_t *answer_count)
 {
         packet_t *packet;
@@ -1276 +1276 @@
 //              fibril_rwlock_read_lock(&tcp_globals.lock);
                 rc = packet_translate_remote(tcp_globals.net_phone, &packet,
-                    IPC_GET_PACKET(call));
+                    IPC_GET_PACKET(*call));
                 if (rc != EOK) {
 //                      fibril_rwlock_read_unlock(&tcp_globals.lock);
                         return rc;
                 }
-                rc = tcp_received_msg(IPC_GET_DEVICE(call), packet, SERVICE_TCP,
-                    IPC_GET_ERROR(call));
+                rc = tcp_received_msg(IPC_GET_DEVICE(*call), packet, SERVICE_TCP,
+                    IPC_GET_ERROR(*call));
 //              fibril_rwlock_read_unlock(&tcp_globals.lock);
                 return rc;
@@ -1323 +1323 @@
         bool keep_on_going = true;
         socket_cores_t local_sockets;
-        int app_phone = IPC_GET_PHONE(&call);
+        int app_phone = IPC_GET_PHONE(call);
         struct sockaddr *addr;
         int socket_id;
@@ -1330 +1330 @@
         fibril_rwlock_t lock;
         ipc_call_t answer;
-        int answer_count;
+        size_t answer_count;
         tcp_socket_data_t *socket_data;
         socket_core_t *socket;
@@ -2502 +2502 @@
         while (true) {
                 ipc_call_t answer;
-                int answer_count;
+                size_t answer_count;
 
                 /* Clear the answer structure */

uspace/srv/net/tl/tcp/tcp_module.c

@@ -87 +87 @@
 
 int tl_module_message_standalone(ipc_callid_t callid, ipc_call_t *call,
-    ipc_call_t *answer, int *answer_count)
+    ipc_call_t *answer, size_t *count)
 {
-        return tcp_message_standalone(callid, call, answer, answer_count);
+        return tcp_message_standalone(callid, call, answer, count);
 }
 

uspace/srv/net/tl/tcp/tcp_module.h

@@ -44 +44 @@
 extern int tcp_initialize(async_client_conn_t);
 extern int tcp_message_standalone(ipc_callid_t, ipc_call_t *, ipc_call_t *,
-    int *);
+    size_t *);
 
 #endif