Changeset 7278cbc9 in mainline for uspace/drv/bus/usb

Timestamp:

2018-01-22T23:53:11Z (8 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e546142

Parents:

3ac86a4

Message:

usbhost: dispose the EP0 properly (+some ehci cleanup while debugging)

Location:

uspace/drv/bus/usb/ehci

Files:

• ehci_bus.c (modified) (1 diff)
• endpoint_list.c (modified) (1 diff)
• hc.c (modified) (2 diffs)

uspace/drv/bus/usb/ehci/ehci_bus.c

@@ -70 +70 @@
         endpoint_init(&ehci_ep->base, dev, desc);
 
-        // TODO: extract USB2 information from desc
-        
         if (dma_buffer_alloc(&ehci_ep->dma_buffer, sizeof(qh_t)))
                 return NULL;

uspace/drv/bus/usb/ehci/endpoint_list.c

@@ -95 +95 @@
 {
         assert(instance);
+        assert(instance->list_head);
         assert(ep);
         assert(ep->qh);

uspace/drv/bus/usb/ehci/hc.c

@@ -236 +236 @@
         assert(ep);
         ehci_endpoint_t *ehci_ep = ehci_endpoint_get(ep);
-        usb_log_debug("HC(%p) dequeue EP(?:%d:%s:%s)", instance,
-            ep->endpoint,
+        usb_log_debug("HC(%p) dequeue EP(%d:%d:%s:%s)", instance,
+            ep->device->address, ep->endpoint,
             usb_str_transfer_type_short(ep->transfer_type),
             usb_str_direction(ep->direction));
@@ -360 +360 @@
 
         if (status & (USB_STS_IRQ_FLAG | USB_STS_ERR_IRQ_FLAG)) {
-
-                LIST_INITIALIZE(completed);
-
                 fibril_mutex_lock(&hc->guard);