Changeset 6ff23ff in mainline for uspace/lib

Timestamp:

2018-05-17T13:46:56Z (7 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

4f8772d4

Parents:

7c3fb9b

git-author:

Jiri Svoboda <jiri@…> (2018-05-16 18:44:36)

git-committer:

Jiri Svoboda <jiri@…> (2018-05-17 13:46:56)

Message:

More comment fixing (ccheck).

Location:

uspace/lib

Files:

• c/arch/mips32/src/syscall.c (modified) (2 diffs)
• c/generic/io/printf_core.c (modified) (4 diffs)
• posix/src/internal/common.h (modified) (1 diff)
• usb/src/port.c (modified) (1 diff)
• usbhid/include/usb/hid/usages/kbdgen.h (modified) (2 diffs)
• usbhid/src/hidpath.c (modified) (4 diffs)

uspace/lib/c/arch/mips32/src/syscall.c

@@ -31 +31 @@
  */
 /** @file
-  * @ingroup libcmips32
+ * @ingroup libcmips32
  */
 
@@ -57 +57 @@
               "r" (__mips_reg_t1),
               "r" (__mips_reg_v0)
-                /*
-                 * We are a function call, although C
-                 * does not know it.
-                 */
+              /*
+               * We are a function call, although C
+               * does not know it.
+               */
             : "%ra"
         );

uspace/lib/c/generic/io/printf_core.c

@@ -1499 +1499 @@
 
                         switch (uc) {
-                        /*
-                         * String and character conversions.
-                         */
+                                /*
+                                 * String and character conversions.
+                                 */
                         case 's':
                                 precision = max(0,  precision);
@@ -1533 +1533 @@
                                 continue;
 
-                        /*
-                         * Floating point values
-                         */
+                                /*
+                                 * Floating point values
+                                 */
                         case 'G':
                         case 'g':
@@ -1554 +1554 @@
                                 continue;
 
-                        /*
-                         * Integer values
-                         */
+                                /*
+                                 * Integer values
+                                 */
                         case 'P':
                                 /* Pointer */
@@ -1586 +1586 @@
                                 break;
 
-                        /* Percentile itself */
                         case '%':
+                                /* Percentile itself */
                                 j = i;
                                 continue;
 
-                        /*
-                         * Bad formatting.
-                         */
+                                /*
+                                 * Bad formatting.
+                                 */
                         default:
                                 /*

uspace/lib/posix/src/internal/common.h

@@ -53 +53 @@
 #define _HIDE_LIBC_SYMBOL(symbol)
 
-/* Checks if the value is a failing error code.
+/** Checks if the value is a failing error code.
+ *
  * If so, writes the error code to errno and returns true.
  */

uspace/lib/usb/src/port.c

@@ -224 +224 @@
                 break;
 
-        /* We first have to stop the fibril in progress. */
         case PORT_CONNECTING:
+                /* We first have to stop the fibril in progress. */
                 port->state = PORT_ERROR;
                 fibril_condvar_broadcast(&port->enabled_cv);

uspace/lib/usbhid/include/usb/hid/usages/kbdgen.h

@@ -32 +32 @@
 /** @file
  * @brief USB HID key codes.
- * @details
+ *
  * This is not a typical header as by default it is equal to empty file.
  * However, by cleverly defining the USB_HIDUT_KBD_KEY you can use it
@@ -39 +39 @@
  * For example, this creates enum for known keys:
  * @code
-#define USB_HIDUT_KBD_KEY(name, usage_id, l, lc, l1, l2) \
-        USB_KBD_KEY_##name = usage_id,
-typedef enum {
-        #include <usb/hidutkbd.h>
-} usb_key_code_t;
- @endcode
+ * #define USB_HIDUT_KBD_KEY(name, usage_id, l, lc, l1, l2) \
+ *     USB_KBD_KEY_##name = usage_id,
+ *
+ * typedef enum {
+ *         #include <usb/hidutkbd.h>
+ * } usb_key_code_t;
+ * @endcode
  *
  * Maybe, it might be better that you would place such enums into separate

uspace/lib/usbhid/src/hidpath.c

@@ -213 +213 @@
 
         switch (flags) {
-        /* Path is somewhere in report_path */
         case USB_HID_PATH_COMPARE_ANYWHERE:
+                /*
+                 * Path is somewhere in report_path
+                 */
                 if (path->depth != 1) {
                         return 1;
@@ -239 +241 @@
 
                 return 1;
-                break;
-
-        /* The paths must be identical */
+
         case USB_HID_PATH_COMPARE_STRICT:
+                /*
+                 * The paths must be identical
+                 */
                 if (report_path->depth != path->depth) {
                         return 1;
@@ -248 +251 @@
                 /* Fallthrough */
 
-        /* Path is prefix of the report_path */
         case USB_HID_PATH_COMPARE_BEGIN:
+                /*
+                 * Path is prefix of the report_path
+                 */
                 report_link = report_path->items.head.next;
                 path_link = path->items.head.next;
@@ -283 +288 @@
                 break;
 
-        /* Path is suffix of report_path */
         case USB_HID_PATH_COMPARE_END:
+                /*
+                 * Path is suffix of report_path
+                 */
                 report_link = report_path->items.head.prev;
                 path_link = path->items.head.prev;