Changeset 6cd9aa6 in mainline for kernel/arch/ia32/src

Timestamp:

2009-02-15T23:13:55Z (16 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

17f168e

Parents:

fa09449

Message:

IRQ handlers are using one superfluous argument and an unused elipsis.
On the other hand, IRQ claim functions would need to be passed the instance
argument.

Location:

kernel/arch/ia32/src

Files:

• drivers/i8254.c (modified) (1 diff)
• interrupt.c (modified) (1 diff)
• smp/apic.c (modified) (1 diff)

kernel/arch/ia32/src/drivers/i8254.c

@@ -62 +62 @@
 static irq_t i8254_irq;
 
-static irq_ownership_t i8254_claim(void)
+static irq_ownership_t i8254_claim(void *instance)
 {
         return IRQ_ACCEPT;
 }
 
-static void i8254_irq_handler(irq_t *irq, void *arg __attribute__((unused)), ...)
+static void i8254_irq_handler(irq_t *irq)
 {
         /*

kernel/arch/ia32/src/interrupt.c

@@ -189 +189 @@
                         ack = true;
                 }
-                irq->handler(irq, irq->arg);
+                irq->handler(irq);
                 spinlock_unlock(&irq->lock);
         } else {

kernel/arch/ia32/src/smp/apic.c

@@ -133 +133 @@
 }
 
-static irq_ownership_t l_apic_timer_claim(void)
+static irq_ownership_t l_apic_timer_claim(void *instance)
 {
         return IRQ_ACCEPT;
 }
 
-static void l_apic_timer_irq_handler(irq_t *irq, void *arg __attribute__((unused)), ...)
+static void l_apic_timer_irq_handler(irq_t *irq)
 {
         /*