Changeset 6c441cf8 in mainline for kernel/arch/mips32

Timestamp:

2008-02-27T11:49:17Z (18 years ago)

Author:

Martin Decky <martin@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

56976a17

Parents:

fdb7795

Message:

code cleanup (mostly signed/unsigned)
allow extra compiler warnings

Location:

kernel/arch/mips32/src

Files:

• cpu/cpu.c (modified) (2 diffs)
• debugger.c (modified) (1 diff)
• drivers/arc.c (modified) (2 diffs)
• mm/tlb.c (modified) (2 diffs)

kernel/arch/mips32/src/cpu/cpu.c

@@ -105 +105 @@
 {
         struct data_t *data;
-        int i;
+        unsigned int i;
 
         if (m->arch.imp_num & 0x80) {
                 /* Count records */
-                for (i=0;imp_data80[i].vendor;i++)
-                        ;
+                for (i = 0; imp_data80[i].vendor; i++);
                 if ((m->arch.imp_num & 0x7f) >= i) {
-                        printf("imp=%d\n",m->arch.imp_num);
+                        printf("imp=%d\n", m->arch.imp_num);
                         return;
                 }
                 data = &imp_data80[m->arch.imp_num & 0x7f];
         } else {
-                for (i=0;imp_data[i].vendor;i++)
-                        ;
+                for (i = 0; imp_data[i].vendor; i++);
                 if (m->arch.imp_num >= i) {
-                        printf("imp=%d\n",m->arch.imp_num);
+                        printf("imp=%d\n", m->arch.imp_num);
                         return;
                 }
@@ -128 +126 @@
         printf("cpu%d: %s %s (rev=%d.%d, imp=%d)\n",
                 m->id, data->vendor, data->model, m->arch.rev_num >> 4, 
-               m->arch.rev_num & 0xf, m->arch.imp_num);
+                m->arch.rev_num & 0xf, m->arch.imp_num);
 }
 

kernel/arch/mips32/src/debugger.c

@@ -209 +209 @@
         ipl_t ipl;
 
-        if (argv->intval < 0 || argv->intval > BKPOINTS_MAX) {
+        if (argv->intval > BKPOINTS_MAX) {
                 printf("Invalid breakpoint number.\n");
                 return 0;

kernel/arch/mips32/src/drivers/arc.c

@@ -119 +119 @@
 {
         cm_resource_list *configdata;
-        int i;
+        unsigned int i;
 
         if (!c->configdatasize)
@@ -162 +162 @@
 static void arc_print_component(arc_component *c)
 {
-        int i;
+        unsigned int i;
 
         printf("%s: ",ctypes[c->type]);

kernel/arch/mips32/src/mm/tlb.c

@@ -573 +573 @@
 void tlb_invalidate_pages(asid_t asid, uintptr_t page, count_t cnt)
 {
-        int i;
+        unsigned int i;
         ipl_t ipl;
         entry_lo_t lo0, lo1;
@@ -584 +584 @@
         ipl = interrupts_disable();
 
-        for (i = 0; i < cnt+1; i+=2) {
+        for (i = 0; i < cnt + 1; i += 2) {
                 hi.value = 0;
                 prepare_entry_hi(&hi, asid, page + i * PAGE_SIZE);