Changeset 6afc9d7 in mainline for uspace/srv/devman

Timestamp:

2015-10-06T19:01:36Z (10 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

0328987

Parents:

f1f7584

Message:

UNIX-like I/O functions should use errno to return error code for many reasons.

Location:

uspace/srv/devman

Files:

• driver.c (modified) (1 diff)
• match.c (modified) (3 diffs)

uspace/srv/devman/driver.c

@@ -142 +142 @@
         /* Check whether the driver's binary exists. */
         struct stat s;
-        if (stat(drv->binary_path, &s) == ENOENT) { /* FIXME!! */
+        if (stat(drv->binary_path, &s) != 0) {
                 log_msg(LOG_DEFAULT, LVL_ERROR, "Driver not found at path `%s'.",
                     drv->binary_path);

uspace/srv/devman/match.c

@@ -31 +31 @@
  */
 
+#include <errno.h>
 #include <fcntl.h>
 #include <io/log.h>
@@ -197 +198 @@
         if (fd < 0) {
                 log_msg(LOG_DEFAULT, LVL_ERROR, "Unable to open `%s' for reading: %s.",
-                    conf_path, str_error(fd));
+                    conf_path, str_error(errno));
                 goto cleanup;
         }
@@ -217 +218 @@
         }
         
-        ssize_t read_bytes = read_all(fd, buf, len);
+        ssize_t read_bytes = read(fd, buf, len);
         if (read_bytes <= 0) {
-                log_msg(LOG_DEFAULT, LVL_ERROR, "Unable to read file '%s' (%zd).", conf_path,
-                    read_bytes);
+                log_msg(LOG_DEFAULT, LVL_ERROR, "Unable to read file '%s' (%d).", conf_path,
+                    errno);
                 goto cleanup;
         }