Changes in uspace/drv/uhci-hcd/iface.c [1998bcd:6acc80f3] in mainline

File:

• uspace/drv/uhci-hcd/iface.c (modified) (16 diffs)

uspace/drv/uhci-hcd/iface.c

@@ -74 +74 @@
             name, target.address, target.endpoint, size, ep->max_packet_size);
 
-//      assert(ep->speed ==
-//          usb_device_keeper_get_speed(&(*hc)->manager, target.address));
+        assert(ep->speed ==
+            usb_device_keeper_get_speed(&(*hc)->manager, target.address));
 //      assert(ep->max_packet_size == max_packet_size);
 //      assert(ep->transfer_type == USB_TRANSFER_CONTROL);
@@ -198 +198 @@
 /*----------------------------------------------------------------------------*/
 static int register_endpoint(
-    ddf_fun_t *fun, usb_address_t address, usb_speed_t ep_speed,
-    usb_endpoint_t endpoint,
+    ddf_fun_t *fun, usb_address_t address, usb_endpoint_t endpoint,
     usb_transfer_type_t transfer_type, usb_direction_t direction,
     size_t max_packet_size, unsigned int interval)
@@ -205 +204 @@
         hc_t *hc = fun_to_hc(fun);
         assert(hc);
-        usb_speed_t speed = usb_device_keeper_get_speed(&hc->manager, address);
-        if (speed >= USB_SPEED_MAX) {
-                speed = ep_speed;
-        }
-        const size_t size =
-            (transfer_type == USB_TRANSFER_INTERRUPT
-            || transfer_type == USB_TRANSFER_ISOCHRONOUS) ?
-            max_packet_size : 0;
+        const usb_speed_t speed =
+            usb_device_keeper_get_speed(&hc->manager, address);
+        const size_t size = max_packet_size;
         int ret;
 
@@ -246 +240 @@
         usb_log_debug("Unregister endpoint %d:%d %d.\n",
             address, endpoint, direction);
-        endpoint_t *ep = usb_endpoint_manager_get_ep(&hc->ep_manager,
-            address, endpoint, direction, NULL);
-        if (ep != NULL) {
-                usb_device_keeper_del_ep(&hc->manager, address, ep);
-        }
         return usb_endpoint_manager_unregister_ep(&hc->ep_manager, address,
             endpoint, direction);
@@ -259 +248 @@
  * @param[in] fun DDF function that was called.
  * @param[in] target USB device to write to.
+ * @param[in] max_packet_size maximum size of data packet the device accepts
  * @param[in] data Source of data.
  * @param[in] size Size of data source.
@@ -266 +256 @@
  */
 static int interrupt_out(
-    ddf_fun_t *fun, usb_target_t target, void *data,
+    ddf_fun_t *fun, usb_target_t target, size_t max_packet_size, void *data,
     size_t size, usbhc_iface_transfer_out_callback_t callback, void *arg)
 {
@@ -287 +277 @@
  * @param[in] fun DDF function that was called.
  * @param[in] target USB device to write to.
+ * @param[in] max_packet_size maximum size of data packet the device accepts
  * @param[out] data Data destination.
  * @param[in] size Size of data source.
@@ -294 +285 @@
  */
 static int interrupt_in(
-    ddf_fun_t *fun, usb_target_t target, void *data,
+    ddf_fun_t *fun, usb_target_t target, size_t max_packet_size, void *data,
     size_t size, usbhc_iface_transfer_in_callback_t callback, void *arg)
 {
@@ -315 +306 @@
  * @param[in] fun DDF function that was called.
  * @param[in] target USB device to write to.
+ * @param[in] max_packet_size maximum size of data packet the device accepts
  * @param[in] data Source of data.
  * @param[in] size Size of data source.
@@ -322 +314 @@
  */
 static int bulk_out(
-    ddf_fun_t *fun, usb_target_t target, void *data,
+    ddf_fun_t *fun, usb_target_t target, size_t max_packet_size, void *data,
     size_t size, usbhc_iface_transfer_out_callback_t callback, void *arg)
 {
@@ -343 +335 @@
  * @param[in] fun DDF function that was called.
  * @param[in] target USB device to write to.
+ * @param[in] max_packet_size maximum size of data packet the device accepts
  * @param[out] data Data destination.
  * @param[in] size Size of data source.
@@ -350 +343 @@
  */
 static int bulk_in(
-    ddf_fun_t *fun, usb_target_t target, void *data,
+    ddf_fun_t *fun, usb_target_t target, size_t max_packet_size, void *data,
     size_t size, usbhc_iface_transfer_in_callback_t callback, void *arg)
 {
@@ -371 +364 @@
  * @param[in] fun DDF function that was called.
  * @param[in] target USB device to write to.
+ * @param[in] max_packet_size maximum size of data packet the device accepts.
  * @param[in] setup_data Data to send with SETUP transfer.
  * @param[in] setup_size Size of data to send with SETUP transfer (always 8B).
@@ -380 +374 @@
  */
 static int control_write(
-    ddf_fun_t *fun, usb_target_t target,
+    ddf_fun_t *fun, usb_target_t target, size_t max_packet_size,
     void *setup_data, size_t setup_size, void *data, size_t size,
     usbhc_iface_transfer_out_callback_t callback, void *arg)
@@ -404 +398 @@
  * @param[in] fun DDF function that was called.
  * @param[in] target USB device to write to.
+ * @param[in] max_packet_size maximum size of data packet the device accepts.
  * @param[in] setup_data Data to send with SETUP packet.
  * @param[in] setup_size Size of data to send with SETUP packet (should be 8B).
@@ -413 +408 @@
  */
 static int control_read(
-    ddf_fun_t *fun, usb_target_t target,
+    ddf_fun_t *fun, usb_target_t target, size_t max_packet_size,
     void *setup_data, size_t setup_size, void *data, size_t size,
     usbhc_iface_transfer_in_callback_t callback, void *arg)