Changeset 5ef85c0 in mainline for uspace/lib/ui/src

Timestamp:

2022-03-17T12:16:03Z (3 years ago)

Author:

Jiri Svoboda <jiri@…>

Branches:

master, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

1026cc4

Parents:

71edd430

git-author:

Jiri Svoboda <jiri@…> (2022-03-16 19:15:43)

git-committer:

Jiri Svoboda <jiri@…> (2022-03-17 12:16:03)

Message:

Scrollbar unit tests

File:

• uspace/lib/ui/src/scrollbar.c (modified) (2 diffs)

uspace/lib/ui/src/scrollbar.c

@@ -49 +49 @@
 #include "../private/scrollbar.h"
 
-/*
- * The kind reader will appreciate that scrollbar thumb dimensions 23:15
- * are chosen such that, after subtracting the frame width (2 times 1),
- * we get 21:13, which is a good approximation of the golden ratio.
- */
 enum {
         /** Scrollbar button width */
@@ -471 +466 @@
         w = scrollbar->rect.p1.x - scrollbar->rect.p0.x -
             2 * ui_scrollbar_btn_len_text;
+        assert(w >= 0);
+        if (w < 0)
+                return EINVAL;
+
         gchar = "\u2592";
         gcharsz = str_size(gchar);