Changeset 5b3cf90 in mainline for uspace/app

Timestamp:

2009-08-02T19:38:02Z (16 years ago)

Author:

Jiri Svoboda <jirik.svoboda@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

fa5526d

Parents:

f019cc07

Message:

Fix warnings in Bdsh and PCI lib.

Location:

uspace/app/bdsh/cmds/modules

Files:

• cp/cp.c (modified) (1 diff)
• ls/ls.c (modified) (1 diff)
• ls/ls.h (modified) (1 diff)
• rm/rm.c (modified) (1 diff)

uspace/app/bdsh/cmds/modules/cp/cp.c

@@ -173 +173 @@
 int cmd_cp(char **argv)
 {
-        unsigned int argc, buffer = 0, verbose = 0;
+        unsigned int argc, verbose = 0;
+        int buffer = 0;
         int c, opt_ind;
         int64_t ret;

uspace/app/bdsh/cmds/modules/ls/ls.c

@@ -90 +90 @@
         int rc;
 
-        if (rc = stat(pathname, &s)) {
+        rc = stat(pathname, &s);
+        if (rc != 0) {
                 /* Odd chance it was deleted from the time readdir() found it */
                 printf("ls: skipping bogus node %s\n", pathname);

uspace/app/bdsh/cmds/modules/ls/ls.h

@@ -7 +7 @@
 #define LS_DIR   2
 
-
-static unsigned int ls_scope(const char *);
 static void ls_scan_dir(const char *, DIR *);
 static void ls_print(const char *, const char *);

uspace/app/bdsh/cmds/modules/rm/rm.c

@@ -210 +210 @@
         }
 
-        if (optind == argc) {
+        if ((unsigned) optind == argc) {
                 cli_error(CL_EFAIL,
                         "%s: insufficient arguments. Try %s --help", cmdname, cmdname);