Changeset 4ff66ae in mainline for uspace/srv/taskman/event.c

Timestamp:

2019-08-07T11:18:35Z (6 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

87a31ef2

Parents:

bb57a00

git-author:

Michal Koutný <xm.koutny+hos@…> (2015-11-13 03:13:03)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2019-08-07 11:18:35)

Message:

taskman: Bind events dump to register handler

• So that no events are processed twice or omitted.

File:

• uspace/srv/taskman/event.c (modified) (2 diffs)

uspace/srv/taskman/event.c

@@ -188 +188 @@
 }
 
-int event_register_listener(task_id_t id, async_sess_t *sess)
+static bool dump_walker(task_t *t, void *arg)
+{
+        event_notify(t, arg);
+        return true;
+}
+
+void event_register_listener(task_id_t id, bool past_events, async_sess_t *sess,
+    ipc_callid_t iid)
 {
         int rc = EOK;
+        /*
+         * We have lock of tasks structures so that we can guarantee
+         * that dump receiver will receive tasks correctly ordered (retval,
+         * exit updates are serialized via exclusive lock).
+         */
         fibril_rwlock_write_lock(&task_hash_table_lock);
         fibril_rwlock_write_lock(&listeners_lock);
@@ -203 +215 @@
         t->sess = sess;
 
+        /*
+         * Answer caller first, so that they are not unnecessarily waiting
+         * while we dump events.
+         */
+        async_answer_0(iid, rc);
+        if (past_events) {
+                task_foreach(&dump_walker, t->sess);
+        }
+
 finish:
         fibril_rwlock_write_unlock(&listeners_lock);
         fibril_rwlock_write_unlock(&task_hash_table_lock);
-        return rc;
-}
-
-static bool dump_walker(task_t *t, void *arg)
-{
-        event_notify(t, arg);
-        return true;
-}
-
-void dump_events(task_id_t receiver_id, ipc_callid_t iid)
-{
-        int rc = EOK;
-        /*
-         * We have shared lock of tasks structures so that we can guarantee
-         * that dump receiver will receive tasks correctly ordered (retval,
-         * exit updates are serialized via exclusive lock).
-         */
-        fibril_rwlock_read_lock(&task_hash_table_lock);
-
-        task_t *receiver = task_get_by_id(receiver_id);
-        if (receiver == NULL) {
-                rc = ENOENT;
-                goto finish;
-        }
-        if (receiver->sess == NULL) {
-                rc = ENOENT;
-                goto finish;
-        }
-
-        /*
-         * Answer caller first, so that they are not unnecessarily waiting
-         * while we dump events.
-         */
-        async_answer_0(iid, rc);
-        task_foreach(&dump_walker, receiver->sess);
-
-finish:
-        fibril_rwlock_read_unlock(&task_hash_table_lock);
         if (rc != EOK) {
                 async_answer_0(iid, rc);