Changeset 4db49344 in mainline for uspace/drv/bus/usb/ehci

Timestamp:

2018-01-23T21:52:28Z (8 years ago)

Author:

Ondřej Hlavatý <aearsis@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

3dd80f8

Parents:

a6afb4c

git-author:

Ondřej Hlavatý <aearsis@…> (2018-01-23 20:49:35)

git-committer:

Ondřej Hlavatý <aearsis@…> (2018-01-23 21:52:28)

Message:

usb: fix wrong design of transfer aborting

Apparently, we didn't do a good job in thinking through the problem.
In older HCs, it was done just wrong - the UHCI implementation commited
a batch that could have been already aborted, and EHCI+OHCI might miss
an interrupt because they commited the batch sooner than they added it
to their checked list.

This commit takes everything from the other end, which is probably the
only right one. Instead of an endpoint having an extra mutex, it
inherits a mutex from the outside. It never locks it though, it just
checks if the mutex is locked and uses it for waiting on condition
variables.

This mutex is supposed to be the one which the HC driver uses for
locking its structures in scheduling. This way, we avoid the ABBA
deadlock completely, while preserving the synchronization on an
endpoint.

The good thing is that this implementation is much easier to extend with
multiple active batches per endpoint.

Location:

uspace/drv/bus/usb/ehci

Files:

• ehci_bus.c (modified) (2 diffs)
• hc.c (modified) (4 diffs)

uspace/drv/bus/usb/ehci/ehci_bus.c

@@ -107 +107 @@
         qh_init(ehci_ep->qh, ep);
         hc_enqueue_endpoint(bus->hc, ep);
-
+        endpoint_set_online(ep, &bus->hc->guard);
         return EOK;
 }
@@ -121 +121 @@
         usb2_bus_ops.endpoint_unregister(ep);
         hc_dequeue_endpoint(hc, ep);
+        /*
+         * Now we can be sure the active transfer will not be completed,
+         * as it's out of the schedule, and HC acknowledged it.
+         */
 
         ehci_endpoint_t *ehci_ep = ehci_endpoint_get(ep);
 
-        /*
-         * Now we can be sure the active transfer will not be completed. But first,
-         * make sure that the handling fibril won't use its link in pending list.
-         */
         fibril_mutex_lock(&hc->guard);
-        if (link_in_use(&ehci_ep->pending_link))
-                /* pending list reference */
-                endpoint_del_ref(ep);
+        endpoint_set_offline_locked(ep);
         list_remove(&ehci_ep->pending_link);
-        fibril_mutex_unlock(&hc->guard);
-
-        /*
-         * Finally, the endpoint shall not be used anywhere else. Finish the
-         * pending batch.
-         */
-        fibril_mutex_lock(&ep->guard);
         usb_transfer_batch_t * const batch = ep->active_batch;
         endpoint_deactivate_locked(ep);
-        fibril_mutex_unlock(&ep->guard);
+        fibril_mutex_unlock(&hc->guard);
 
         if (batch) {

uspace/drv/bus/usb/ehci/hc.c

@@ -302 +302 @@
         endpoint_t * const ep = batch->ep;
         ehci_endpoint_t * const ehci_ep = ehci_endpoint_get(ep);
-
-        /* creating local reference */
-        endpoint_add_ref(ep);
-
-        fibril_mutex_lock(&ep->guard);
-        endpoint_activate_locked(ep, batch);
-
         ehci_transfer_batch_t *ehci_batch = ehci_transfer_batch_get(batch);
-        const int err = ehci_transfer_batch_prepare(ehci_batch);
-        if (err) {
-                endpoint_deactivate_locked(ep);
-                fibril_mutex_unlock(&ep->guard);
-                /* dropping local reference */
-                endpoint_del_ref(ep);
+
+        int err;
+
+        if ((err = ehci_transfer_batch_prepare(ehci_batch)))
+                return err;
+
+        fibril_mutex_lock(&hc->guard);
+
+        if ((err = endpoint_activate_locked(ep, batch))) {
+                fibril_mutex_unlock(&hc->guard);
                 return err;
         }
@@ -321 +318 @@
         usb_log_debug("HC(%p): Committing BATCH(%p)", hc, batch);
         ehci_transfer_batch_commit(ehci_batch);
-        fibril_mutex_unlock(&ep->guard);
 
         /* Enqueue endpoint to the checked list */
-        fibril_mutex_lock(&hc->guard);
         usb_log_debug2("HC(%p): Appending BATCH(%p)", hc, batch);
-
-        /* local reference -> pending list reference */
         list_append(&ehci_ep->pending_link, &hc->pending_endpoints);
+
         fibril_mutex_unlock(&hc->guard);
-
         return EOK;
 }
@@ -368 +361 @@
                                 = list_get_instance(current, ehci_endpoint_t, pending_link);
 
-                        fibril_mutex_lock(&ep->base.guard);
                         ehci_transfer_batch_t *batch
                                 = ehci_transfer_batch_get(ep->base.active_batch);
@@ -376 +368 @@
                                 endpoint_deactivate_locked(&ep->base);
                                 list_remove(current);
-                                endpoint_del_ref(&ep->base);
                                 hc_reset_toggles(&batch->base, &ehci_ep_toggle_reset);
                                 usb_transfer_batch_finish(&batch->base);
                         }
-                        fibril_mutex_unlock(&ep->base.guard);
                 }
                 fibril_mutex_unlock(&hc->guard);