Changeset 4b1c7c6f in mainline for kernel/generic/src/mm

Timestamp:

2018-03-16T20:57:16Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

6be2c13

Parents:

973be387

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-16 20:51:59)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-16 20:57:16)

Message:

Clean up PAGE_* flags.

Remove "nop flags", they are confusing for readers and any benefit they would
gain in self-documentation they lose in being used inconsistently.

Remove "PAGE_READ", the only place it's used meaningfully is the incomplete
RISC-V implementation, and most call sites assume read is implied.

Location:

kernel/generic/src/mm

Files:

• as.c (modified) (1 diff)
• km.c (modified) (1 diff)

kernel/generic/src/mm/as.c

@@ -1217 +1217 @@
 NO_TRACE static unsigned int area_flags_to_page_flags(unsigned int aflags)
 {
-        unsigned int flags = PAGE_USER | PAGE_PRESENT;
-
-        if (aflags & AS_AREA_READ)
-                flags |= PAGE_READ;
+        unsigned int flags = PAGE_USER;
+
+        // TODO: AS_AREA_READ currently has no effect.
+        // Readability is implied.
 
         if (aflags & AS_AREA_WRITE)

kernel/generic/src/mm/km.c

@@ -257 +257 @@
         if (frame) {
                 page = km_map(frame, PAGE_SIZE,
-                    PAGE_READ | PAGE_WRITE | PAGE_CACHEABLE);
+                    PAGE_WRITE | PAGE_CACHEABLE);
                 if (!page) {
                         frame_free(frame, 1);