Changeset 4b1c7c6f in mainline for kernel/arch/ia32/include/arch/mm/page.h

Timestamp:

2018-03-16T20:57:16Z (7 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

6be2c13

Parents:

973be387

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-16 20:51:59)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-03-16 20:57:16)

Message:

Clean up PAGE_* flags.

Remove "nop flags", they are confusing for readers and any benefit they would
gain in self-documentation they lose in being used inconsistently.

Remove "PAGE_READ", the only place it's used meaningfully is the incomplete
RISC-V implementation, and most call sites assume read is implied.

File:

• kernel/arch/ia32/include/arch/mm/page.h (modified) (2 diffs)

kernel/arch/ia32/include/arch/mm/page.h

@@ -109 +109 @@
         get_pt_flags((pte_t *) (ptl0), (size_t) (i))
 #define GET_PTL2_FLAGS_ARCH(ptl1, i) \
-        PAGE_PRESENT
+        0
 #define GET_PTL3_FLAGS_ARCH(ptl2, i) \
-        PAGE_PRESENT
+        0
 #define GET_FRAME_FLAGS_ARCH(ptl3, i) \
         get_pt_flags((pte_t *) (ptl3), (size_t) (i))
@@ -185 +185 @@
 
         return ((!p->page_cache_disable) << PAGE_CACHEABLE_SHIFT |
-            (!p->present) << PAGE_PRESENT_SHIFT |
+            (!p->present) << PAGE_NOT_PRESENT_SHIFT |
             p->uaccessible << PAGE_USER_SHIFT |
-            1 << PAGE_READ_SHIFT |
             p->writeable << PAGE_WRITE_SHIFT |
             1 << PAGE_EXEC_SHIFT |