Changeset 48902fa in mainline

Timestamp:

2011-11-11T19:37:46Z (14 years ago)

Author:

Maurizio Lombardi <m.lombardi85@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c2e50d7

Parents:

20a3465

Message:

Return error if someone is trying to hardlink directories.

File:

• uspace/srv/fs/mfs/mfs_ops.c (modified) (3 diffs)

uspace/srv/fs/mfs/mfs_ops.c

@@ -664 +664 @@
         struct mfs_node *child = cfn->data;
         struct mfs_sb_info *sbi = parent->instance->sbi;
+        bool destroy_dentry = false;
 
         mfsdebug("%s()\n", __FUNCTION__);
@@ -672 +673 @@
         int r = mfs_insert_dentry(parent, name, child->ino_i->index);
         if (r != EOK)
-                goto exit_error;
-
-        child->ino_i->i_nlinks++;
-        child->ino_i->dirty = true;
+                return r;
 
         if (S_ISDIR(child->ino_i->i_mode)) {
+                if (child->ino_i->i_nlinks != 1) {
+                        /* It's not possible to hardlink directories in MFS */
+                        destroy_dentry = true;
+                        r = EMLINK;
+                        goto exit;
+                }
                 r = mfs_insert_dentry(child, ".", child->ino_i->index);
-                if (r != EOK)
-                        goto exit_error;
+                if (r != EOK) {
+                        destroy_dentry = true;
+                        goto exit;
+                }
 
                 r = mfs_insert_dentry(child, "..", parent->ino_i->index);
-                if (r != EOK)
-                        goto exit_error;
+                if (r != EOK) {
+                        destroy_dentry = true;
+                        goto exit;
+                }
 
                 parent->ino_i->i_nlinks++;
@@ -690 +698 @@
         }
 
-exit_error:
+exit:
+        if (destroy_dentry) {
+                int r2 = mfs_remove_dentry(parent, name);
+                if (r2 != EOK)
+                        r = r2;
+        } else {
+                child->ino_i->i_nlinks++;
+                child->ino_i->dirty = true;
+        }
         return r;
 }