Changeset 4874c2d in mainline for kernel/arch

Timestamp:

2006-10-17T20:32:35Z (19 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

b14e35f2

Parents:

8513ad7

Message:

Do not copy notification config out of the IRQ structure.
Add the notify member, that toggles notifications on and off instead.
This is good for preventing other tasks from registering the notification
while the notification config is stored outside the IRQ structure.
It should also help to implement the cleanup code.

File:

• kernel/arch/ppc32/src/drivers/cuda.c (modified) (4 diffs)

kernel/arch/ppc32/src/drivers/cuda.c

@@ -64 +64 @@
 static volatile uint8_t *cuda = NULL;
 static irq_t cuda_irq;          /**< Cuda's IRQ. */
-
-static ipc_notif_cfg_t saved_notif_cfg;
-
 
 static char lchars[0x80] = {
@@ -255 +252 @@
 static void cuda_irq_handler(irq_t *irq, void *arg, ...)
 {
-        if (irq->notif_cfg.answerbox)
+        if (irq->notif_cfg.notify && irq->notif_cfg.answerbox)
                 ipc_irq_send_notif(irq);
         else {
@@ -277 +274 @@
 void cuda_grab(void)
 {
-        if (cuda_irq.notif_cfg.answerbox) {
-                saved_notif_cfg = cuda_irq.notif_cfg;
-                cuda_irq.notif_cfg.answerbox = NULL;
-                cuda_irq.notif_cfg.code = NULL;
-                cuda_irq.notif_cfg.method = 0;
-                cuda_irq.notif_cfg.counter = 0;
-        }
+        cuda_irq.notif_cfg.notify = false;
 }
 
@@ -290 +281 @@
 void cuda_release(void)
 {
-        if (saved_notif_cfg.answerbox)
-                cuda_irq.notif_cfg = saved_notif_cfg;
+        if (cuda_irq.notif_cfg.answerbox)
+                cuda_irq.notif_cfg.notify = true;
 }