Changeset 46b881c in mainline for uspace/drv


Ignore:
Timestamp:
2011-01-29T11:36:41Z (15 years ago)
Author:
Martin Decky <martin@…>
Branches:
lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export
Children:
0b6931a, 8add9ca5
Parents:
e26a4633 (diff), ffa2c8ef (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.
Message:

IPC/async: strictly isolate the use of low-level IPC methods (ipc_*) and async framework methods (async_*) in user code, do not allow a mixture of both in a single source file

Benefits for future plans

  • The async framework could use different communication style under the hood, but keeping the same high-level API
  • The async framework can be integrated more tightly with sessions without potential problems of intermixing session-aware async methods with session-unaware low-level methods in user code
  • The async_serialize_start()/_end() can be deprecated more easily
Location:
uspace/drv
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • uspace/drv/ns8250/ns8250.c

    re26a4633 r46b881c  
    256256       
    257257        if (dev->parent_phone > 0) {
    258                 ipc_hangup(dev->parent_phone);
     258                async_hangup(dev->parent_phone);
    259259                dev->parent_phone = 0;
    260260        }
     
    888888                ns8250_get_props(dev, &baud_rate, &parity, &word_length,
    889889                    &stop_bits);
    890                 ipc_answer_4(callid, EOK, baud_rate, parity, word_length,
     890                async_answer_4(callid, EOK, baud_rate, parity, word_length,
    891891                    stop_bits);
    892892                break;
     
    899899                ret = ns8250_set_props(dev, baud_rate, parity, word_length,
    900900                    stop_bits);
    901                 ipc_answer_0(callid, ret);
     901                async_answer_0(callid, ret);
    902902                break;
    903903               
    904904        default:
    905                 ipc_answer_0(callid, ENOTSUP);
     905                async_answer_0(callid, ENOTSUP);
    906906        }
    907907}
  • uspace/drv/pciintel/pci.c

    re26a4633 r46b881c  
    478478                    "the device.\n");
    479479                delete_pci_bus_data(bus_data);
    480                 ipc_hangup(dev->parent_phone);
     480                async_hangup(dev->parent_phone);
    481481                return rc;
    482482        }       
     
    496496                printf(NAME ": failed to enable configuration ports.\n");
    497497                delete_pci_bus_data(bus_data);
    498                 ipc_hangup(dev->parent_phone);
     498                async_hangup(dev->parent_phone);
    499499                hw_res_clean_resource_list(&hw_resources);
    500500                return EADDRNOTAVAIL;
Note: See TracChangeset for help on using the changeset viewer.