Changeset 46577995 in mainline for uspace/srv/ns/task.c

Timestamp:

2018-01-04T20:50:52Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Children:

e211ea04

Parents:

facacc71

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:47:53)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:50:52)

Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

After this commit, HelenOS is free of code that mixes error codes with non-error
values on the assumption that error codes are negative.

File:

• uspace/srv/ns/task.c (modified) (5 diffs)

uspace/srv/ns/task.c

@@ -151 +151 @@
 static list_t pending_wait;
 
-int task_init(void)
+errno_t task_init(void)
 {
         if (!hash_table_create(&task_hash_table, 0, 0, &task_hash_table_ops)) {
@@ -225 +225 @@
 }
 
-int ns_task_id_intro(ipc_call_t *call)
+errno_t ns_task_id_intro(ipc_call_t *call)
 {
         task_id_t id = MERGE_LOUP32(IPC_GET_ARG1(*call), IPC_GET_ARG2(*call));
@@ -264 +264 @@
 }
 
-static int get_id_by_phone(sysarg_t phone_hash, task_id_t *id)
+static errno_t get_id_by_phone(sysarg_t phone_hash, task_id_t *id)
 {
         ht_link_t *link = hash_table_find(&phone_to_id, &phone_hash);
@@ -276 +276 @@
 }
 
-int ns_task_retval(ipc_call_t *call)
+errno_t ns_task_retval(ipc_call_t *call)
 {
         task_id_t id = call->in_task_id;
@@ -296 +296 @@
 }
 
-int ns_task_disconnect(ipc_call_t *call)
+errno_t ns_task_disconnect(ipc_call_t *call)
 {
         task_id_t id;
-        int rc = get_id_by_phone(call->in_phone_hash, &id);
+        errno_t rc = get_id_by_phone(call->in_phone_hash, &id);
         if (rc != EOK)
                 return rc;