Changeset 46577995 in mainline for uspace/drv/hid/usbhid/generic


Ignore:
Timestamp:
2018-01-04T20:50:52Z (8 years ago)
Author:
Jiří Zárevúcky <zarevucky.jiri@…>
Children:
e211ea04
Parents:
facacc71
git-author:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:47:53)
git-committer:
Jiří Zárevúcky <zarevucky.jiri@…> (2018-01-04 20:50:52)
Message:

Use errno_t in all uspace and kernel code.

Change type of every variable, parameter and return value that holds an
<errno.h> constant to either errno_t (the usual case), or sys_errno_t
(some places in kernel). This is for the purpose of self-documentation,
as well as for type-checking with a bit of type definition hackery.

After this commit, HelenOS is free of code that mixes error codes with non-error
values on the assumption that error codes are negative.

Location:
uspace/drv/hid/usbhid/generic
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • uspace/drv/hid/usbhid/generic/hiddev.c

    rfacacc71 r46577995  
    6060
    6161static size_t usb_generic_hid_get_event_length(ddf_fun_t *fun);
    62 static int usb_generic_hid_get_event(ddf_fun_t *fun, uint8_t *buffer,
     62static errno_t usb_generic_hid_get_event(ddf_fun_t *fun, uint8_t *buffer,
    6363    size_t size, size_t *act_size, int *event_nr, unsigned int flags);
    64 static int usb_generic_hid_client_connected(ddf_fun_t *fun);
     64static errno_t usb_generic_hid_client_connected(ddf_fun_t *fun);
    6565static size_t usb_generic_get_report_descriptor_length(ddf_fun_t *fun);
    66 static int usb_generic_get_report_descriptor(ddf_fun_t *fun, uint8_t *desc,
     66static errno_t usb_generic_get_report_descriptor(ddf_fun_t *fun, uint8_t *desc,
    6767    size_t size, size_t *actual_size);
    6868
    … …  
    102102}
    103103
    104 static int usb_generic_hid_get_event(ddf_fun_t *fun, uint8_t *buffer,
     104static errno_t usb_generic_hid_get_event(ddf_fun_t *fun, uint8_t *buffer,
    105105    size_t size, size_t *act_size, int *event_nr, unsigned int flags)
    106106{
    … …  
    143143}
    144144
    145 static int usb_generic_get_report_descriptor(ddf_fun_t *fun, uint8_t *desc,
     145static errno_t usb_generic_get_report_descriptor(ddf_fun_t *fun, uint8_t *desc,
    146146    size_t size, size_t *actual_size)
    147147{
    … …  
    160160}
    161161
    162 static int usb_generic_hid_client_connected(ddf_fun_t *fun)
     162static errno_t usb_generic_hid_client_connected(ddf_fun_t *fun)
    163163{
    164164        usb_log_debug("Generic HID: Client connected.\n");
    … …  
    180180}
    181181
    182 int usb_generic_hid_init(usb_hid_dev_t *hid_dev, void **data)
     182errno_t usb_generic_hid_init(usb_hid_dev_t *hid_dev, void **data)
    183183{
    184184        usb_hid_gen_fun_t *hid_fun;
    … …  
    202202        ddf_fun_set_ops(fun, &usb_generic_hid_ops);
    203203
    204         int rc = ddf_fun_bind(fun);
     204        errno_t rc = ddf_fun_bind(fun);
    205205        if (rc != EOK) {
    206206                usb_log_error("Could not bind DDF function: %s.\n",

  • uspace/drv/hid/usbhid/generic/hiddev.h

    rfacacc71 r46577995  
    5151} usb_hid_gen_fun_t;
    5252
    53 extern int usb_generic_hid_init(usb_hid_dev_t *, void **);
     53extern errno_t usb_generic_hid_init(usb_hid_dev_t *, void **);
    5454extern void usb_generic_hid_deinit(usb_hid_dev_t *, void *);
    5555extern bool usb_generic_hid_polling_callback(usb_hid_dev_t *, void *);
Note: See TracChangeset for help on using the changeset viewer.