Changeset 4339f09 in mainline for uspace/lib/c

Timestamp:

2013-06-28T07:46:31Z (12 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e52b4b5

Parents:

3de67b4c (diff), dba3e2c (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Mostly C style (obey clang suggestions)

Merge from lp:~vojtech-horky/helenos/misc.

Most changes driven by warnings/errors from clang, such as type
redefinitions (typedef struct …) or possibly uninitizalied
variables. Clang still emits some warnings but a lot less than
before . As a result, kernel can be built with clang/-Werror.

Also updated mkext2.py to work with Python 3 again.

Location:

uspace/lib/c

Files:

• generic/devman.c (modified) (1 diff)
• include/bd_srv.h (modified) (2 diffs)
• include/cc.h (added)
• include/io/con_srv.h (modified) (2 diffs)
• include/mem.h (modified) (1 diff)

uspace/lib/c/generic/devman.c

@@ -413 +413 @@
         sysarg_t dretval;
         
-        exch = devman_exchange_begin_blocking(LOC_PORT_CONSUMER);
+        exch = devman_exchange_begin_blocking(DEVMAN_CLIENT);
         
         ipc_call_t answer;

uspace/lib/c/include/bd_srv.h

@@ -57 +57 @@
 } bd_srv_t;
 
-typedef struct bd_ops {
+struct bd_ops {
         int (*open)(bd_srvs_t *, bd_srv_t *);
         int (*close)(bd_srv_t *);
@@ -65 +65 @@
         int (*get_block_size)(bd_srv_t *, size_t *);
         int (*get_num_blocks)(bd_srv_t *, aoff64_t *);
-} bd_ops_t;
+};
 
 extern void bd_srvs_init(bd_srvs_t *);

uspace/lib/c/include/io/con_srv.h

@@ -66 +66 @@
 } con_srv_t;
 
-typedef struct con_ops {
+struct con_ops {
         int (*open)(con_srvs_t *, con_srv_t *);
         int (*close)(con_srv_t *);
@@ -83 +83 @@
         void (*set_cursor_visibility)(con_srv_t *, bool);
         int (*get_event)(con_srv_t *, cons_event_t *);
-} con_ops_t;
+};
 
 extern void con_srvs_init(con_srvs_t *);

uspace/lib/c/include/mem.h

@@ -37 +37 @@
 
 #include <sys/types.h>
+#include <cc.h>
 
 extern void *memset(void *, int, size_t)
-    __attribute__ ((optimize("-fno-tree-loop-distribute-patterns")));
+    ATTRIBUTE_OPTIMIZE("-fno-tree-loop-distribute-patterns");
 extern void *memcpy(void *, const void *, size_t)
-    __attribute__ ((optimize("-fno-tree-loop-distribute-patterns")));
+    ATTRIBUTE_OPTIMIZE("-fno-tree-loop-distribute-patterns");
 extern void *memmove(void *, const void *, size_t);
 extern int memcmp(const void *, const void *, size_t);