Changeset 4339f09 in mainline for kernel

Timestamp:

2013-06-28T07:46:31Z (13 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

e52b4b5

Parents:

3de67b4c (diff), dba3e2c (diff)
Note: this is a merge changeset, the changes displayed below correspond to the merge itself.
Use the (diff) links above to see all the changes relative to each parent.

Message:

Mostly C style (obey clang suggestions)

Merge from lp:~vojtech-horky/helenos/misc.

Most changes driven by warnings/errors from clang, such as type
redefinitions (typedef struct …) or possibly uninitizalied
variables. Clang still emits some warnings but a lot less than
before . As a result, kernel can be built with clang/-Werror.

Also updated mkext2.py to work with Python 3 again.

Location:

kernel

Files:

• Makefile (modified) (1 diff)
• generic/include/cc.h (added)
• generic/include/lib/memfnc.h (modified) (1 diff)
• test/print/print4.c (modified) (2 diffs)

kernel/Makefile

@@ -105 +105 @@
 CLANG_CFLAGS = $(INCLUDES_FLAGS) -O$(OPTIMIZATION) -imacros $(CONFIG_HEADER) \
         -ffreestanding -fno-builtin -nostdlib -nostdinc \
-        -Wall -Wextra -Wno-unused-parameter -Wmissing-prototypes \
+        -Wall -Werror -Wextra -Wno-unused-parameter -Wmissing-prototypes \
         -Werror-implicit-function-declaration -Wwrite-strings \
         -integrated-as \

kernel/generic/include/lib/memfnc.h

@@ -37 +37 @@
 
 #include <typedefs.h>
+#include <cc.h>
 
 extern void *memset(void *, int, size_t)
-    __attribute__ ((optimize("-fno-tree-loop-distribute-patterns")));
+    ATTRIBUTE_OPTIMIZE("-fno-tree-loop-distribute-patterns");
 extern void *memcpy(void *, const void *, size_t)
-    __attribute__ ((optimize("-fno-tree-loop-distribute-patterns")));
+    ATTRIBUTE_OPTIMIZE("-fno-tree-loop-distribute-patterns");
 
 #endif

kernel/test/print/print4.c

@@ -36 +36 @@
         uint8_t group;
         for (group = 1; group < 4; group++) {
-                TPRINTF("%#" PRIx8 ": ", group << 5);
+                TPRINTF("%#x: ", group << 5);
                 
                 uint8_t index;
@@ -52 +52 @@
         
         for (group = 4; group < 8; group++) {
-                TPRINTF("%#" PRIx8 ": ", group << 5);
+                TPRINTF("%#x: ", group << 5);
                 
                 uint8_t index;