Changeset 3fb5a3e in mainline for uspace/drv/usbhub/ports.c

Timestamp:

2011-05-28T14:34:43Z (15 years ago)

Author:

Vojtech Horky <vojtechhorky@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

af6136d

Parents:

400735e

Message:

Do not delete hub info too early

When a hub is disconnected during port change (device adding) the
structure was deleted and accessed *later* from the device adding
routine. Because allocator is next fit, the error went unnoticed.

File:

• uspace/drv/usbhub/ports.c (modified) (2 diffs)

uspace/drv/usbhub/ports.c

@@ -407 +407 @@
         free(arg);
 
+        fibril_mutex_lock(&data->hub->pending_ops_mutex);
+        assert(data->hub->pending_ops_count > 0);
+        data->hub->pending_ops_count--;
+        fibril_condvar_signal(&data->hub->pending_ops_cv);
+        fibril_mutex_unlock(&data->hub->pending_ops_mutex);
+
+
         return EOK;
 }
@@ -452 +459 @@
                 return ENOMEM;
         }
+        fibril_mutex_lock(&hub->pending_ops_mutex);
+        hub->pending_ops_count++;
+        fibril_mutex_unlock(&hub->pending_ops_mutex);
         fibril_add_ready(fibril);