Changeset 33b8d024 in mainline for uspace/lib/usbdev/src

Timestamp:

2018-01-16T20:38:46Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2467b41

Parents:

d39c46e0

Message:

Remove const qualifier from the argument of free() and realloc(),
as well as in numerous other variables that hold ownership of memory.

By convention, a pointer that holds ownership is _never_ qualified by const.
This is reflected in the standard type signature of free() and realloc().
Allowing const pointers to hold ownership may seem superficially convenient,
but is actually quite confusing to experienced C programmers.

Location:

uspace/lib/usbdev/src

Files:

• devpoll.c (modified) (1 diff)
• recognise.c (modified) (1 diff)
• request.c (modified) (1 diff)

uspace/lib/usbdev/src/devpoll.c

@@ -80 +80 @@
 {
         assert(arg);
-        const polling_data_t *data = arg;
+        polling_data_t *data = arg;
         /* Helper to reduce typing. */
         const usb_device_auto_polling_t *params = &data->auto_polling;

uspace/lib/usbdev/src/recognise.c

@@ -61 +61 @@
  */
 static errno_t usb_add_match_id(match_id_list_t *matches, int score,
-    const char *match_str)
+    char *match_str)
 {
         assert(matches);

uspace/lib/usbdev/src/request.c

@@ -475 +475 @@
 errno_t usb_request_get_full_configuration_descriptor_alloc(
     usb_pipe_t *pipe, int index,
-    const void **descriptor_ptr, size_t *descriptor_size)
+    void **descriptor_ptr, size_t *descriptor_size)
 {
         errno_t rc;