Changeset 33b8d024 in mainline for uspace/lib/drv

Timestamp:

2018-01-16T20:38:46Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2467b41

Parents:

d39c46e0

Message:

Remove const qualifier from the argument of free() and realloc(),
as well as in numerous other variables that hold ownership of memory.

By convention, a pointer that holds ownership is _never_ qualified by const.
This is reflected in the standard type signature of free() and realloc().
Allowing const pointers to hold ownership may seem superficially convenient,
but is actually quite confusing to experienced C programmers.

Location:

uspace/lib/drv

Files:

• generic/private/driver.h (modified) (2 diffs)
• generic/remote_audio_mixer.c (modified) (2 diffs)
• generic/remote_audio_pcm.c (modified) (1 diff)
• include/audio_mixer_iface.h (modified) (1 diff)
• include/audio_pcm_iface.h (modified) (1 diff)

uspace/lib/drv/generic/private/driver.h

@@ -57 +57 @@
         
         /** Device name */
-        const char *name;
+        char *name;
         
         /** Driver-specific data associated with this device */
@@ -84 +84 @@
         
         /** Function name */
-        const char *name;
+        char *name;
         
         /** List of device ids for driver matching */

uspace/lib/drv/generic/remote_audio_mixer.c

@@ -94 +94 @@
  * @return Error code.
  */
-errno_t audio_mixer_get_info(async_exch_t *exch, const char **name, unsigned *items)
+errno_t audio_mixer_get_info(async_exch_t *exch, char **name, unsigned *items)
 {
         if (!exch)
@@ -131 +131 @@
  */
 errno_t audio_mixer_get_item_info(async_exch_t *exch, unsigned item,
-    const char **name, unsigned *levels)
+    char **name, unsigned *levels)
 {
         if (!exch)

uspace/lib/drv/generic/remote_audio_pcm.c

@@ -184 +184 @@
  * @note Caller is responsible for freeing newly allocated memory.
  */
-errno_t audio_pcm_get_info_str(audio_pcm_sess_t *sess, const char **name)
+errno_t audio_pcm_get_info_str(audio_pcm_sess_t *sess, char **name)
 {
         if (!name)

uspace/lib/drv/include/audio_mixer_iface.h

@@ -43 +43 @@
 #include "ddf/driver.h"
 
-errno_t audio_mixer_get_info(async_exch_t *, const char **, unsigned *);
+errno_t audio_mixer_get_info(async_exch_t *, char **, unsigned *);
 errno_t audio_mixer_get_item_info(async_exch_t *, unsigned,
-    const char **, unsigned *);
+    char **, unsigned *);
 errno_t audio_mixer_get_item_level(async_exch_t *, unsigned, unsigned *);
 errno_t audio_mixer_set_item_level(async_exch_t *, unsigned, unsigned);

uspace/lib/drv/include/audio_pcm_iface.h

@@ -80 +80 @@
 void audio_pcm_close(audio_pcm_sess_t *);
 
-errno_t audio_pcm_get_info_str(audio_pcm_sess_t *, const char **);
+errno_t audio_pcm_get_info_str(audio_pcm_sess_t *, char **);
 errno_t audio_pcm_test_format(audio_pcm_sess_t *, unsigned *, unsigned *,
     pcm_sample_format_t *);