Changeset 33b8d024 in mainline for uspace/lib/c

Timestamp:

2018-01-16T20:38:46Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2467b41

Parents:

d39c46e0

Message:

Remove const qualifier from the argument of free() and realloc(),
as well as in numerous other variables that hold ownership of memory.

By convention, a pointer that holds ownership is _never_ qualified by const.
This is reflected in the standard type signature of free() and realloc().
Allowing const pointers to hold ownership may seem superficially convenient,
but is actually quite confusing to experienced C programmers.

Location:

uspace/lib/c

Files:

• generic/malloc.c (modified) (2 diffs)
• include/ipc/devman.h (modified) (1 diff)
• include/malloc.h (modified) (1 diff)

uspace/lib/c/generic/malloc.c

@@ -874 +874 @@
  *
  */
-void *realloc(const void *addr, const size_t size)
+void *realloc(void * const addr, const size_t size)
 {
         if (size == 0) {
@@ -988 +988 @@
  *
  */
-void free(const void *addr)
+void free(void * const addr)
 {
         if (addr == NULL)

uspace/lib/c/include/ipc/devman.h

@@ -74 +74 @@
         /** Id of device model.
          */
-        const char *id;
+        char *id;
         /** Relevancy of device-to-driver match.
          * The higher is the product of scores specified for the device by the bus driver and by the leaf driver,

uspace/lib/c/include/malloc.h

@@ -38 +38 @@
 #include <stddef.h>
 
-extern void *malloc(const size_t size)
+extern void *malloc(size_t size)
     __attribute__((malloc));
-extern void *calloc(const size_t nmemb, const size_t size)
+extern void *calloc(size_t nmemb, size_t size)
     __attribute__((malloc));
-extern void *memalign(const size_t align, const size_t size)
+extern void *memalign(size_t align, size_t size)
     __attribute__((malloc));
-extern void *realloc(const void *addr, const size_t size)
+extern void *realloc(void *addr, size_t size)
     __attribute__((warn_unused_result));
-extern void free(const void *addr);
+extern void free(void *addr);
 extern void *heap_check(void);