Changeset 33b8d024 in mainline for uspace/app

Timestamp:

2018-01-16T20:38:46Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

2467b41

Parents:

d39c46e0

Message:

Remove const qualifier from the argument of free() and realloc(),
as well as in numerous other variables that hold ownership of memory.

By convention, a pointer that holds ownership is _never_ qualified by const.
This is reflected in the standard type signature of free() and realloc().
Allowing const pointers to hold ownership may seem superficially convenient,
but is actually quite confusing to experienced C programmers.

Location:

uspace/app

Files:

• bdsh/compl.c (modified) (2 diffs)
• edit/search_impl.h (modified) (1 diff)
• mixerctl/mixerctl.c (modified) (2 diffs)
• wavplay/dplay.c (modified) (1 diff)
• wavplay/drec.c (modified) (1 diff)

uspace/app/bdsh/compl.c

@@ -69 +69 @@
 
         /** Pointer inside list of directories */
-        const char **path;
+        const char *const *path;
         /** If not @c NULL, should be freed in the end. */
-        const char **path_list;
+        char **path_list;
         /** Current open directory */
         DIR *dir;
@@ -219 +219 @@
                 cs->path_list[0] = dirname;
                 cs->path_list[1] = NULL;
-                cs->path = cs->path_list;
+                /* The second const ensures that we can't assign a const
+                 * string to the non-const array. */
+                cs->path = (const char *const *) cs->path_list;
 
         } else if (cs->is_command) {

uspace/app/edit/search_impl.h

@@ -43 +43 @@
         /* Note: This structure is opaque for the user. */
 
-        const wchar_t *pattern;
+        wchar_t *pattern;
         size_t pattern_length;
         ssize_t *back_table;

uspace/app/mixerctl/mixerctl.c

@@ -49 +49 @@
 static void print_levels(async_exch_t *exch)
 {
-        const char* name = NULL;
+        char* name = NULL;
         unsigned count = 0;
         errno_t ret = audio_mixer_get_info(exch, &name, &count);
@@ -59 +59 @@
 
         for (unsigned i = 0; i < count; ++i) {
-                const char *name = NULL;
+                char *name = NULL;
                 unsigned levels = 0, current = 0;
                 errno_t ret =

uspace/app/wavplay/dplay.c

@@ -353 +353 @@
         }
 
-        const char* info = NULL;
+        char* info = NULL;
         ret = audio_pcm_get_info_str(session, &info);
         if (ret != EOK) {

uspace/app/wavplay/drec.c

@@ -195 +195 @@
         }
 
-        const char* info = NULL;
+        char* info = NULL;
         ret = audio_pcm_get_info_str(session, &info);
         if (ret != EOK) {