Changeset 25a179e in mainline for uspace/app/trace

Timestamp:

2017-12-20T19:51:45Z (8 years ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

f96b6c8

Parents:

d4a829e

Message:

IPC return values are always errno constants. Adjust types to reflect that.

In principle, IPC server is not allowed to return non-errno values via
the "main" return value, because kernel interprets it (e.g. EHANGUP).
It's still possible to return arbitrary additional return values alongside EOK,
which are not interpreted in normal communication.

Location:

uspace/app/trace

Files:

• ipcp.c (modified) (2 diffs)
• trace.c (modified) (2 diffs)

uspace/app/trace/ipcp.c

@@ -250 +250 @@
         sysarg_t method;
         sysarg_t service;
-        sysarg_t retval;
+        int retval;
         proto_t *proto;
         int cphone;
@@ -265 +265 @@
         
         if ((display_mask & DM_IPC) != 0) {
-                printf("Response to %d: retval=%" PRIdn ", args = (%" PRIun ", "
+                printf("Response to %d: retval=%d, args = (%" PRIun ", "
                     "%" PRIun ", %" PRIun ", %" PRIun ", %" PRIun ")\n",
                     hash, retval, IPC_GET_ARG1(*answer),

uspace/app/trace/trace.c

@@ -260 +260 @@
 
 
-static void print_sc_retval(sysarg_t retval, val_type_t val_type)
+static void print_sc_retval(int retval, val_type_t val_type)
 {
         printf(" -> ");
@@ -279 +279 @@
 }
 
-static void sc_ipc_call_async_fast(sysarg_t *sc_args, sysarg_t sc_rc)
+static void sc_ipc_call_async_fast(sysarg_t *sc_args, int sc_rc)
 {
         ipc_call_t call;
         sysarg_t phoneid;
         
-        if (sc_rc != (sysarg_t) EOK)
+        if (sc_rc != EOK)
                 return;