Changes in uspace/lib/block/block.c [dd8b6a8:2463df9] in mainline

File:

• uspace/lib/block/block.c (modified) (15 diffs)

uspace/lib/block/block.c

@@ -55 +55 @@
 #include "block.h"
 
-#define MAX_WRITE_RETRIES 10
-
 /** Lock protecting the device connection list */
 static FIBRIL_MUTEX_INITIALIZE(dcl_lock);
@@ -81 +79 @@
         void *bb_buf;
         aoff64_t bb_addr;
-        aoff64_t pblocks;    /**< Number of physical blocks */
         size_t pblock_size;  /**< Physical block size. */
         cache_t *cache;
@@ -106 +103 @@
 
 static int devcon_add(service_id_t service_id, async_sess_t *sess,
-    size_t bsize, aoff64_t dev_size, bd_t *bd)
+    size_t bsize, bd_t *bd)
 {
         devcon_t *devcon;
@@ -121 +118 @@
         devcon->bb_addr = 0;
         devcon->pblock_size = bsize;
-        devcon->pblocks = dev_size;
         devcon->cache = NULL;
         
@@ -168 +164 @@
                 return rc;
         }
-
-        aoff64_t dev_size;
-        rc = bd_get_num_blocks(bd, &dev_size);
+        
+        rc = devcon_add(service_id, sess, bsize, bd);
         if (rc != EOK) {
                 bd_close(bd);
@@ -177 +172 @@
         }
         
-        rc = devcon_add(service_id, sess, bsize, dev_size, bd);
-        if (rc != EOK) {
-                bd_close(bd);
-                async_hangup(sess);
-                return rc;
-        }
-        
         return EOK;
 }
@@ -194 +182 @@
         if (devcon->cache)
                 (void) block_cache_fini(service_id);
-        
-        (void)bd_sync_cache(devcon->bd, 0, 0);
         
         devcon_remove(devcon);
@@ -363 +349 @@
         fibril_mutex_initialize(&b->lock);
         b->refcnt = 1;
-        b->write_failures = 0;
         b->dirty = false;
         b->toxic = false;
@@ -388 +373 @@
         block_t *b;
         link_t *link;
-        aoff64_t p_ba;
+
         int rc;
         
@@ -397 +382 @@
         
         cache = devcon->cache;
-
-        /* Check whether the logical block (or part of it) is beyond
-         * the end of the device or not.
-         */
-        p_ba = ba_ltop(devcon, ba);
-        p_ba += cache->blocks_cluster;
-        if (p_ba >= devcon->pblocks) {
-                /* This request cannot be satisfied */
-                return EIO;
-        }
-
 
 retry:
@@ -484 +458 @@
                                          * another block next time.
                                          */
-                                        if (b->write_failures < MAX_WRITE_RETRIES) {
-                                                b->write_failures++;
-                                                fibril_mutex_unlock(&b->lock);
-                                                goto retry;
-                                        } else {
-                                                printf("Too many errors writing block %"
-                                                    PRIuOFF64 "from device handle %" PRIun "\n"
-                                                    "SEVERE DATA LOSS POSSIBLE\n",
-                                                    b->lba, devcon->service_id);
-                                        }
-                                } else
-                                        b->write_failures = 0;
-
+                                        fibril_mutex_unlock(&b->lock);
+                                        goto retry;
+                                }
                                 b->dirty = false;
                                 if (!fibril_mutex_trylock(&cache->lock)) {
@@ -613 +577 @@
                 rc = write_blocks(devcon, block->pba, cache->blocks_cluster,
                     block->data, block->size);
-                if (rc == EOK)
-                        block->write_failures = 0;
                 block->dirty = false;
         }
@@ -640 +602 @@
                                  */
                                 block->refcnt++;
-
-                                if (block->write_failures < MAX_WRITE_RETRIES) {
-                                        block->write_failures++;
-                                        fibril_mutex_unlock(&block->lock);
-                                        fibril_mutex_unlock(&cache->lock);
-                                        goto retry;
-                                } else {
-                                        printf("Too many errors writing block %"
-                                            PRIuOFF64 "from device handle %" PRIun "\n"
-                                            "SEVERE DATA LOSS POSSIBLE\n",
-                                            block->lba, devcon->service_id);
-                                }
+                                fibril_mutex_unlock(&block->lock);
+                                fibril_mutex_unlock(&cache->lock);
+                                goto retry;
                         }
                         /*
@@ -817 +770 @@
         devcon_t *devcon = devcon_search(service_id);
         assert(devcon);
-
+        
         return bd_get_num_blocks(devcon->bd, nblocks);
 }
@@ -879 +832 @@
  *
  * @return Allocated TOC structure.
- * @return EOK on success or negative error code.
- *
- */
-int block_read_toc(service_id_t service_id, uint8_t session, void *buf,
-    size_t bufsize)
+ * @return NULL on failure.
+ *
+ */
+toc_block_t *block_get_toc(service_id_t service_id, uint8_t session)
 {
         devcon_t *devcon = devcon_search(service_id);
-        
-        assert(devcon);
-        return bd_read_toc(devcon->bd, session, buf, bufsize);
+        toc_block_t *toc = NULL;
+        int rc;
+        
+        assert(devcon);
+        
+        toc = (toc_block_t *) malloc(sizeof(toc_block_t));
+        if (toc == NULL)
+                return NULL;
+        
+        rc = bd_read_toc(devcon->bd, session, toc, sizeof(toc_block_t));
+        if (rc != EOK) {
+                free(toc);
+                return NULL;
+        }
+        
+        return toc;
 }