Changes in uspace/drv/usbmouse/mouse.c [019cff6:21bb58d] in mainline

File:

• uspace/drv/usbmouse/mouse.c (modified) (3 diffs)

uspace/drv/usbmouse/mouse.c

@@ -37 +37 @@
 #include <usb/debug.h>
 #include <errno.h>
-#include <str_error.h>
 #include <ipc/mouse.h>
 
@@ -65 +64 @@
 
                 size_t actual_size;
-                int rc;
 
-                /*
-                 * Error checking note:
-                 * - failure when starting a session is considered
-                 *   temporary (e.g. out of phones, next try might succeed)
-                 * - failure of transfer considered fatal (probably the
-                 *   device was unplugged)
-                 * - session closing not checked (shall not fail anyway)
-                 */
+                /* FIXME: check for errors. */
+                usb_endpoint_pipe_start_session(&mouse->poll_pipe);
 
-                rc = usb_endpoint_pipe_start_session(&mouse->poll_pipe);
-                if (rc != EOK) {
-                        usb_log_warning("Failed to start session, will try again: %s.\n",
-                            str_error(rc));
-                        continue;
-                }
-
-                rc = usb_endpoint_pipe_read(&mouse->poll_pipe,
+                usb_endpoint_pipe_read(&mouse->poll_pipe,
                     buffer, buffer_size, &actual_size);
 
                 usb_endpoint_pipe_end_session(&mouse->poll_pipe);
-
-                if (rc != EOK) {
-                        usb_log_error("Failed reading mouse input: %s.\n",
-                            str_error(rc));
-                        break;
-                }
-
-                usb_log_debug2("got buffer: %s.\n",
-                    usb_debug_str_buffer(buffer, buffer_size, 0));
 
                 uint8_t butt = buffer[0];
@@ -139 +115 @@
         }
 
-        /*
-         * Device was probably unplugged.
-         * Hang-up the phone to the console.
-         * FIXME: release allocated memory.
-         */
-        async_hangup(mouse->console_phone);
-        mouse->console_phone = -1;
-
-        usb_log_error("Mouse polling fibril terminated.\n");
-
         return EOK;
 }