Changeset 2057572 in mainline for kernel/generic/src

Timestamp:

2007-03-27T23:40:25Z (19 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

399ece9

Parents:

8d37a06

Message:

The Ultimate Solution To Illegal Virtual Aliases.
It is better to avoid them completely than to fight them.
Switch the sparc64 port to 16K pages. The TLBs and TSBs
continue to operate with 8K pages only. Page tables and
other generic parts operate with 16K pages.

Because the MMU doesn't support 16K directly, each 16K
page is emulated by a pair of 8K pages. With 16K pages,
illegal aliases cannot be created in 16K D-cache.

Location:

kernel/generic/src

Files:

• console/klog.c (modified) (1 diff)
• ddi/ddi.c (modified) (2 diffs)
• lib/rd.c (modified) (1 diff)
• mm/as.c (modified) (3 diffs)
• mm/backend_anon.c (modified) (2 diffs)
• mm/backend_elf.c (modified) (2 diffs)
• time/clock.c (modified) (1 diff)

kernel/generic/src/console/klog.c

@@ -91 +91 @@
 
         sysinfo_set_item_val("klog.faddr", NULL, (unative_t) faddr);
-        sysinfo_set_item_val("klog.fcolor", NULL, (unative_t)
-                PAGE_COLOR((uintptr_t) klog));
         sysinfo_set_item_val("klog.pages", NULL, 1 << KLOG_ORDER);
         sysinfo_set_item_val("klog.devno", NULL, devno);

kernel/generic/src/ddi/ddi.c

@@ -100 +100 @@
  *      syscall, ENOENT if there is no task matching the specified ID or the
  *      physical address space is not enabled for mapping and ENOMEM if there
- *      was a problem in creating address space area. ENOTSUP is returned when
- *      an attempt to create an illegal address alias is detected.
+ *      was a problem in creating address space area.
  */
 static int ddi_physmem_map(uintptr_t pf, uintptr_t vp, count_t pages, int flags)
@@ -140 +139 @@
                 return ENOENT;
         }
-
-#ifdef CONFIG_VIRT_IDX_DCACHE
-        if (PAGE_COLOR(parea->vbase) != PAGE_COLOR(vp)) {
-                /*
-                 * Refuse to create an illegal address alias.
-                 */
-                spinlock_unlock(&parea_lock);
-                interrupts_restore(ipl);
-                return ENOTSUP;
-        }
-#endif /* CONFIG_VIRT_IDX_DCACHE */
-
         spinlock_unlock(&parea_lock);
 

kernel/generic/src/lib/rd.c

@@ -91 +91 @@
         sysinfo_set_item_val("rd.address.physical", NULL, (unative_t)
                 KA2PA((void *) header + hsize));
-        sysinfo_set_item_val("rd.address.color", NULL, (unative_t)
-                PAGE_COLOR((uintptr_t) header + hsize));
 
         return RE_OK;

kernel/generic/src/mm/as.c

@@ -614 +614 @@
  * or ENOMEM if there was a problem in allocating destination address space
  * area. ENOTSUP is returned if the address space area backend does not support
- * sharing or if the kernel detects an attempt to create an illegal address
- * alias.
+ * sharing.
  */
 int as_area_share(as_t *src_as, uintptr_t src_base, size_t acc_size,
@@ -667 +666 @@
                 return EPERM;
         }
-
-#ifdef CONFIG_VIRT_IDX_DCACHE
-        if (!(dst_flags_mask & AS_AREA_EXEC)) {
-                if (PAGE_COLOR(src_area->base) != PAGE_COLOR(dst_base)) {
-                        /*
-                         * Refuse to create an illegal address alias.
-                         */
-                        mutex_unlock(&src_area->lock);
-                        mutex_unlock(&src_as->lock);
-                        interrupts_restore(ipl);
-                        return ENOTSUP;
-                }
-        }
-#endif /* CONFIG_VIRT_IDX_DCACHE */
 
         /*
@@ -902 +887 @@
                          * ASID.
                          */
-                         ASSERT(old_as->asid != ASID_INVALID);
-                         list_append(&old_as->inactive_as_with_asid_link,
-                             &inactive_as_with_asid_head);
+                        ASSERT(old_as->asid != ASID_INVALID);
+                        list_append(&old_as->inactive_as_with_asid_link,
+                            &inactive_as_with_asid_head);
                 }
                 mutex_unlock(&old_as->lock);

kernel/generic/src/mm/backend_anon.c

@@ -158 +158 @@
                 panic("Could not insert used space.\n");
                 
-#ifdef CONFIG_VIRT_IDX_DCACHE
-        if (dirty && PAGE_COLOR(PA2KA(frame)) != PAGE_COLOR(addr)) {
-                /*
-                 * By writing to the frame using kernel virtual address,
-                 * we have created an illegal virtual alias. We now have to
-                 * invalidate cachelines belonging to addr on all processors
-                 * so that they will be reloaded with the new content on next
-                 * read.
-                 */
-                dcache_flush_frame(addr, frame);
-                dcache_shootdown_start(DCACHE_INVL_FRAME, PAGE_COLOR(addr), frame);
-                dcache_shootdown_finalize();
-        }
-#endif
-
         return AS_PF_OK;
 }
@@ -241 +226 @@
 /** @}
  */
-

kernel/generic/src/mm/backend_elf.c

@@ -209 +209 @@
         if (!used_space_insert(area, ALIGN_DOWN(addr, PAGE_SIZE), 1))
                 panic("Could not insert used space.\n");
-
-#ifdef CONFIG_VIRT_IDX_DCACHE
-        if (dirty && PAGE_COLOR(PA2KA(frame)) != PAGE_COLOR(addr)) {
-                /*
-                 * By writing to the frame using kernel virtual address,
-                 * we have created an illegal virtual alias. We now have to
-                 * invalidate cachelines belonging to addr on all processors
-                 * so that they will be reloaded with the new content on next
-                 * read.
-                 */
-                dcache_flush_frame(addr, frame);
-                dcache_shootdown_start(DCACHE_INVL_FRAME, PAGE_COLOR(addr), frame);
-                dcache_shootdown_finalize();
-        }
-#endif
 
         return AS_PF_OK;
@@ -356 +341 @@
 /** @}
  */
-

kernel/generic/src/time/clock.c

@@ -105 +105 @@
          */
         sysinfo_set_item_val("clock.cacheable", NULL, (unative_t) true);
-        sysinfo_set_item_val("clock.fcolor", NULL, (unative_t)
-                PAGE_COLOR(clock_parea.vbase));
         sysinfo_set_item_val("clock.faddr", NULL, (unative_t) faddr);
 }