Changeset 16d748ee in mainline for uspace/lib/c/generic/async

Timestamp:

2020-01-05T03:04:38Z (5 years ago)

Author:

Matthieu Riolo <matthieu.riolo@…>

Children:

66b1075

Parents:

2f04bdd

git-author:

Matthieu Riolo <matthieu.riolo@…> (2019-11-30 20:47:26)

git-committer:

Matthieu Riolo <matthieu.riolo@…> (2020-01-05 03:04:38)

Message:

Removing implicit handler from async/server and taskman.
Correcting taskman methods and it's fallback handler
Simplifying connecting to taskman

Location:

uspace/lib/c/generic/async

Files:

• client.c (modified) (2 diffs)
• server.c (modified) (3 diffs)

uspace/lib/c/generic/async/client.c

@@ -857 +857 @@
         if (sess == NULL) {
                 ipc_hangup(phone);
-        }else {
+        } else {
                 sess->iface = iface;
         }
@@ -915 +915 @@
         if (sess == NULL) {
                 ipc_hangup(phone);
-        }else {
+        } else {
                 sess->iface = iface;
         }

uspace/lib/c/generic/async/server.c

@@ -216 +216 @@
 }
 
-static async_port_handler_t implicit_connection = NULL;
-
-/** Setter for implicit_connection function pointer.
- *
- * @param conn Function that will implement a new connection fibril for
- *             unrouted calls.
- *
- */
-void async_set_implicit_connection(async_port_handler_t conn)
-{
-        assert(implicit_connection == NULL);
-        implicit_connection = conn;
-}
-
 static fibril_rmutex_t client_mutex;
 static hash_table_t client_hash_table;
@@ -407 +393 @@
  *                    either a callback connection that was opened by
  *                    accepting the IPC_M_CONNECT_TO_ME call.
- *                    Alternatively, it is zero when we are opening
- *                    implicit connection.
  * @param handler     Connection handler.
  * @param data        Client argument to pass to the connection handler.
@@ -979 +963 @@
         /* Route the call according to its request label */
         errno_t rc = route_call(call);
-        if (rc == EOK) {
+        if (rc == EOK)
                 return;
-        } else if (implicit_connection != NULL) {
-                connection_t *conn = calloc(1, sizeof(connection_t));
-                if (!conn) {
-                        ipc_answer_0(call->cap_handle, ENOMEM);
-                        return;
-                }
-
-                async_new_connection(conn, call->task_id, call, implicit_connection, NULL);
-                return;
-        }
 
         // TODO: Log the error.
-
         if (call->cap_handle != CAP_NIL)
                 /* Unknown call from unknown phone - hang it up */