Changeset 151c050 in mainline for kernel/generic/src/proc/thread.c

Timestamp:

2024-01-15T14:33:03Z (18 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

c7ceacf

Parents:

8996582

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2023-04-15 16:15:29)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2024-01-15 14:33:03)

Message:

Rethink scheduler entry points

Changes the way scheduler is entered, to eliminate some unnecessary
locking and interrupt disables.

File:

• kernel/generic/src/proc/thread.c (modified) (4 diffs)

kernel/generic/src/proc/thread.c

@@ -314 +314 @@
         current_initialize((current_t *) thread->kstack);
 
-        ipl_t ipl = interrupts_disable();
-        thread->saved_ipl = interrupts_read();
-        interrupts_restore(ipl);
-
         str_cpy(thread->name, THREAD_NAME_BUFLEN, name);
 
@@ -518 +514 @@
         }
 
-        irq_spinlock_lock(&THREAD->lock, true);
-        THREAD->state = Exiting;
-        irq_spinlock_unlock(&THREAD->lock, true);
-
-        scheduler();
-
-        panic("should never be reached");
+        scheduler_enter(Exiting);
+        unreachable();
 }
 
@@ -623 +614 @@
         }
 
-        ipl_t ipl = interrupts_disable();
-        irq_spinlock_lock(&THREAD->lock, false);
-        THREAD->state = Sleeping;
-        scheduler_locked(ipl);
+        scheduler_enter(Sleeping);
 
         if (deadline != DEADLINE_NEVER && !timeout_unregister(&timeout)) {
@@ -736 +724 @@
 
         (void) waitq_sleep_timeout(&wq, usec);
+}
+
+/** Allow other threads to run. */
+void thread_yield(void)
+{
+        assert(THREAD != NULL);
+        scheduler_enter(Running);
 }