Changeset 150adbd2 in mainline for uspace/app

Timestamp:

2025-06-29T10:08:40Z (4 months ago)

Author:

Miroslav Cimerman <mc@…>

Children:

40ab4901

Parents:

93ea452

Message:

hr: add NOOP metadata type

File:

• uspace/app/hrctl/hrctl.c (modified) (9 diffs)

uspace/app/hrctl/hrctl.c

@@ -52 +52 @@
 static errno_t fill_config_devs(int, char **, hr_config_t *);
 static errno_t get_vol_configs_from_sif(const char *, hr_config_t **, size_t *);
-static int create_from_config(hr_t *, const char *);
-static int create_from_argv(hr_t *, int, char **);
+static int create_from_config(hr_t *, const char *, uint8_t);
+static int create_from_argv(hr_t *, int, char **, uint8_t);
 static int handle_create(hr_t *, int, char **);
 static int assemble_from_config(hr_t *, const char *);
@@ -70 +70 @@
     "  -h, --help                                Display this message and exit.\n"
     "\n"
-    "  -c, --create                              Create a volume, options:\n"
+    "  -c, --create [--no_meta]                  Create a volume, options:\n"
     "      name {-l , --level level} device...   manual device specification, or\n"
     "      -f configuration.sif                  create from configuration file.\n"
@@ -108 +108 @@
     "\n"
     "Notes:\n"
+    "  Add --no_meta after --create to disable storing on-disk metadata.\n"
     "  Simulating an extent failure with -m volume -f index is dangerous. It marks\n"
     "  metadata as dirty in other healthy extents, and zeroes out the superblock\n"
@@ -341 +342 @@
 }
 
-static int create_from_config(hr_t *hr, const char *config_path)
+static int create_from_config(hr_t *hr, const char *config_path,
+    uint8_t vol_flags)
 {
         hr_config_t *vol_configs = NULL;
@@ -351 +353 @@
                 return EXIT_FAILURE;
         }
+
+        for (size_t i = 0; i < vol_count; i++)
+                vol_configs[i].vol_flags |= vol_flags;
 
         for (size_t i = 0; i < vol_count; i++) {
@@ -368 +373 @@
 }
 
-static int create_from_argv(hr_t *hr, int argc, char **argv)
+static int create_from_argv(hr_t *hr, int argc, char **argv, uint8_t vol_flags)
 {
         /* we need name + --level + arg + at least one extent */
@@ -381 +386 @@
                 return EXIT_FAILURE;
         }
+
+        vol_config->vol_flags |= vol_flags;
 
         const char *name = argv[optind++];
@@ -441 +448 @@
 {
         int rc;
+        uint8_t vol_flags = 0;
 
         if (optind >= argc) {
                 printf(NAME ": no arguments to --create\n");
                 return EXIT_FAILURE;
+        }
+
+        if (str_cmp(argv[optind], "--no_meta") == 0) {
+                vol_flags |= HR_VOL_FLAG_NOOP_META;
+                optind++;
         }
 
@@ -461 +474 @@
                 }
 
-                rc = create_from_config(hr, config_path);
+                rc = create_from_config(hr, config_path, vol_flags);
         } else {
-                rc = create_from_argv(hr, argc, argv);
+                rc = create_from_argv(hr, argc, argv, vol_flags);
         }