Changes in uspace/drv/vhc/hub/hub.c [6cb58e6:0f21c0c] in mainline

File:

• uspace/drv/vhc/hub/hub.c (modified) (8 diffs)

uspace/drv/vhc/hub/hub.c

@@ -34 +34 @@
  */
 #include <usb/classes/classes.h>
+#include <usbvirt/hub.h>
 #include <usbvirt/device.h>
 #include <errno.h>
 #include <str_error.h>
-#include <assert.h>
 #include <stdlib.h>
-#include <ddf/driver.h>
-#include <usb/debug.h>
+#include <driver.h>
 
 #include "hub.h"
@@ -96 +95 @@
  * @param index Port index (one based).
  */
-static void hub_init_port(hub_port_t *port, hub_t *hub, size_t index)
+static void hub_init_port(hub_port_t *port, size_t index)
 {
         port->connected_device = NULL;
@@ -102 +101 @@
         port->state = HUB_PORT_STATE_NOT_CONFIGURED;
         port->status_change = 0;
-        port->hub = hub;
 }
 
@@ -113 +111 @@
         size_t i;
         for (i = 0; i < HUB_PORT_COUNT; i++) {
-                hub_init_port(&hub->ports[i], hub, i + 1);
+                hub_init_port(&hub->ports[i], i + 1);
         }
         hub->custom_data = NULL;
-        hub->signal_changes = true;
         fibril_mutex_initialize(&hub->guard);
 }
@@ -231 +228 @@
         }
 
-        usb_log_debug("Setting port %zu to state %d.\n", port_index, state);
-
         switch (state) {
                 case HUB_PORT_STATE_POWERED_OFF:
@@ -240 +235 @@
                         break;
                 case HUB_PORT_STATE_RESUMING:
-                        port->state = state;
                         set_port_state_delayed(hub, port_index,
                             10, state, HUB_PORT_STATE_ENABLED);
                         break;
                 case HUB_PORT_STATE_RESETTING:
-                        port->state = state;
                         set_port_state_delayed(hub, port_index,
                             10, state, HUB_PORT_STATE_ENABLED);
@@ -421 +414 @@
 {
         assert(port != NULL);
-        uint16_t old_value = port->status_change;
         port->status_change |= change;
-        usb_log_debug("Changing status change on %zu: %04x => %04x\n",
-            port->index,
-            (unsigned int) old_value, (unsigned int) port->status_change);
-        port->hub->signal_changes = true;
 }
 
@@ -439 +427 @@
         assert(port != NULL);
         port->status_change &= (~change);
-        port->hub->signal_changes = true;
 }