Changeset 0db0df2 in mainline for uspace/lib/c/generic

Timestamp:

2025-04-07T17:53:53Z (3 months ago)

Author:

Jiří Zárevúcky <zarevucky.jiri@…>

Branches:

master

Children:

45226285, 93de384

Parents:

8f8818ac

git-author:

Jiří Zárevúcky <zarevucky.jiri@…> (2025-04-07 16:41:57)

git-committer:

Jiří Zárevúcky <zarevucky.jiri@…> (2025-04-07 17:53:53)

Message:

Hash table improvements

Implement hash_table_foreach macro, analogous to list_foreach.

Remove superfluous argument to hash_table_find_next().
(If the user needs to recheck the part of the list already
checked by hash_table_find(), they can just rerun that function.)

Add hash argument to hash_table_ops_t::key_equal.
The big change here is that users with big keys can store the hash
value alongside key in their entries, and for the low low cost of
sizeof(size_t) bytes eliminate a bunch of expensive key comparisons.

Also added a hash function for strings and arbitrary data.
Found this one by asking ChatGPT, because the latency of accesses
to my book collection is currently a couple of hours.

+ Some drive-by unused #include removal.

Location:

uspace/lib/c/generic/async

Files:

• ports.c (modified) (3 diffs)
• server.c (modified) (2 diffs)

uspace/lib/c/generic/async/ports.c

@@ -50 +50 @@
 #include <as.h>
 #include <abi/mm/as.h>
-#include "../private/libc.h"
 #include "../private/fibril.h"
 
@@ -115 +114 @@
 }
 
-static bool interface_key_equal(const void *key, const ht_link_t *item)
+static bool interface_key_equal(const void *key, size_t hash, const ht_link_t *item)
 {
         const iface_t *iface = key;
@@ -143 +142 @@
 }
 
-static bool port_key_equal(const void *key, const ht_link_t *item)
+static bool port_key_equal(const void *key, size_t hash, const ht_link_t *item)
 {
         const port_id_t *port_id = key;

uspace/lib/c/generic/async/server.c

@@ -242 +242 @@
 }
 
-static bool client_key_equal(const void *key, const ht_link_t *item)
+static bool client_key_equal(const void *key, size_t, const ht_link_t *item)
 {
         const task_id_t *in_task_id = key;
@@ -502 +502 @@
 }
 
-static bool notification_key_equal(const void *key, const ht_link_t *item)
+static bool notification_key_equal(const void *key, size_t hash, const ht_link_t *item)
 {
         const sysarg_t *id = key;