Changeset 0882a9a in mainline for arch/mips32/src/mm/tlb.c

Timestamp:

2006-02-10T16:11:14Z (19 years ago)

Author:

Jakub Jermar <jakub@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

ecbdc724

Parents:

d0a0f12

Message:

Make use of one unused bit in PTE formats of amd64, ia32 and mips32 to store 1 in valid mappings.
This helps to distinguish valid entries from not present entries with 0 content (i.e. not present
entries with PFN 0 and other bits cleared).

File:

• arch/mips32/src/mm/tlb.c (modified) (9 diffs)

arch/mips32/src/mm/tlb.c

@@ -46 +46 @@
 static pte_t *find_mapping_and_check(__address badvaddr);
 
-static void prepare_entry_lo(entry_lo_t *lo, bool g, bool v, bool d, int c, __address pfn);
+static void prepare_entry_lo(entry_lo_t *lo, bool g, bool v, bool d, bool cacheable, __address pfn);
 static void prepare_entry_hi(entry_hi_t *hi, asid_t asid, __address addr);
 
@@ -105 +105 @@
 
         prepare_entry_hi(&hi, AS->asid, badvaddr);
-        prepare_entry_lo(&lo, pte->lo.g, pte->lo.v, pte->lo.d, pte->lo.c, pte->lo.pfn);
+        prepare_entry_lo(&lo, pte->g, pte->p, pte->d, pte->cacheable, pte->pfn);
 
         /*
@@ -179 +179 @@
         pte->a = 1;
 
-        prepare_entry_lo(&lo, pte->lo.g, pte->lo.v, pte->lo.d, pte->lo.c, pte->lo.pfn);
+        prepare_entry_lo(&lo, pte->g, pte->p, pte->d, pte->cacheable, pte->pfn);
 
         /*
@@ -253 +253 @@
          */
         pte->a = 1;
-        pte->lo.d = 1;
-
-        prepare_entry_lo(&lo, pte->lo.g, pte->lo.v, pte->w, pte->lo.c, pte->lo.pfn);
+        pte->d = 1;
+
+        prepare_entry_lo(&lo, pte->g, pte->p, pte->w, pte->cacheable, pte->pfn);
 
         /*
@@ -338 +338 @@
          */     
         pte = page_mapping_find(AS, badvaddr);
-        if (pte && pte->lo.v) {
+        if (pte && pte->p) {
                 /*
                  * Mapping found in page tables.
@@ -355 +355 @@
                          */
                         pte = page_mapping_find(AS, badvaddr);
-                        ASSERT(pte && pte->lo.v);
+                        ASSERT(pte && pte->p);
                         return pte;
                 }
@@ -371 +371 @@
          * Handler cannot succeed if the mapping is marked as invalid.
          */
-        if (!pte->lo.v) {
+        if (!pte->p) {
                 printf("Invalid mapping.\n");
                 return NULL;
@@ -379 +379 @@
 }
 
-void prepare_entry_lo(entry_lo_t *lo, bool g, bool v, bool d, int c, __address pfn)
+void prepare_entry_lo(entry_lo_t *lo, bool g, bool v, bool d, bool cacheable, __address pfn)
 {
         lo->value = 0;
@@ -385 +385 @@
         lo->v = v;
         lo->d = d;
-        lo->c = c;
+        lo->c = cacheable ? PAGE_CACHEABLE_EXC_WRITE : PAGE_UNCACHED;
         lo->pfn = pfn;
 }