Changeset 07498c1 in mainline

Timestamp:

2011-11-07T08:37:51Z (14 years ago)

Author:

Jan Vesely <jano.vesely@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

05920d23

Parents:

e3e0953

Message:

libusbhid: Change int parameter to unsigned.

Location:

uspace/lib/usbhid

Files:

• include/usb/hid/usages/consumer.h (modified) (1 diff)
• src/consumer.c (modified) (3 diffs)

uspace/lib/usbhid/include/usb/hid/usages/consumer.h

@@ -37 +37 @@
 #define LIBUSBHID_CONSUMER_H_
 
-const char *usbhid_multimedia_usage_to_str(int usage);
+const char *usbhid_multimedia_usage_to_str(unsigned usage);
 
 #endif /* LIBUSBHID_CONSUMER_H_ */

uspace/lib/usbhid/src/consumer.c

@@ -38 +38 @@
 #include <usb/hid/usages/consumer.h>
 
-static const char *usbhid_consumer_usage_str[0x29d] = {
+static const char *usbhid_consumer_usage_str[] = {
         [0x01] = "Consumer Control",
         [0x02] = "Numeric Key Pad",
@@ -358 +358 @@
         [0x13e] = "Reserved",
         [0x13f] = "Reserved",
-        [0x140] = "Reserved", 
+        [0x140] = "Reserved",
         [0x141] = "Reserved",
         [0x142] = "Reserved",
@@ -717 +717 @@
  * @retval HelenOS key code corresponding to the given USB Consumer Page Usage.
  */
-const char *usbhid_multimedia_usage_to_str(int usage)
+const char *usbhid_multimedia_usage_to_str(unsigned usage)
 {
-        size_t map_length = sizeof(usbhid_consumer_usage_str) / sizeof(char *);
+        static const size_t map_length =
+            sizeof(usbhid_consumer_usage_str) / sizeof(char *);
 
-        if ((usage < 0) || ((size_t)usage >= map_length))
+        if (usage >= map_length)
                 return "Unknown usage";
 
-        /*! @todo What if the usage is not in the table? */
         return usbhid_consumer_usage_str[usage];
 }