Changeset 05b59393 in mainline for uspace/drv/audio

Timestamp:

2017-10-04T18:02:14Z (8 years ago)

Author:

jzr <zarevucky.jiri@…>

Branches:

lfn, master, serial, ticket/834-toolchain-update, topic/msim-upgrade, topic/simplify-dev-export

Children:

c9e88da

Parents:

0b2d369

Message:

Fix a couple of benign clang warnings.
No change in semantics.

File:

• uspace/drv/audio/sb16/dsp.c (modified) (3 diffs)

uspace/drv/audio/sb16/dsp.c

@@ -75 +75 @@
                 [DSP_NO_BUFFER] = "NO BUFFER",
         };
-        if (state < ARRAY_SIZE(state_names))
+        if ((size_t)state < ARRAY_SIZE(state_names))
                 return state_names[state];
         return "UNKNOWN";
@@ -144 +144 @@
 {
         dsp_write(dsp, SET_SAMPLING_RATE_OUTPUT);
-        dsp_write(dsp, rate >> 8);
-        dsp_write(dsp, rate & 0xff);
-        ddf_log_verbose("Sampling rate: %hhx:%hhx.", rate >> 8, rate & 0xff);
+        uint8_t rate_lo = rate & 0xff;
+        uint8_t rate_hi = rate >> 8;
+        dsp_write(dsp, rate_hi);
+        dsp_write(dsp, rate_lo);
+        ddf_log_verbose("Sampling rate: %hhx:%hhx.", rate_hi, rate_lo);
 }
 
@@ -202 +204 @@
         
         return ret;
-}
-
-static inline size_t sample_count(pcm_sample_format_t format, size_t byte_count)
-{
-        return byte_count / pcm_sample_format_size(format);
 }