source: mainline/uspace/srv/ns/task.c@ 0db0df2

Last change on this file since 0db0df2 was 0db0df2, checked in by Jiří Zárevúcky <zarevucky.jiri@…>, 3 months ago

Hash table improvements

Implement hash_table_foreach macro, analogous to list_foreach.

Remove superfluous argument to hash_table_find_next().
(If the user needs to recheck the part of the list already
checked by hash_table_find(), they can just rerun that function.)

Add hash argument to hash_table_ops_t::key_equal.
The big change here is that users with big keys can store the hash
value alongside key in their entries, and for the low low cost of
sizeof(size_t) bytes eliminate a bunch of expensive key comparisons.

Also added a hash function for strings and arbitrary data.
Found this one by asking ChatGPT, because the latency of accesses
to my book collection is currently a couple of hours.

+ Some drive-by unused #include removal.

  • Property mode set to 100644
File size: 7.8 KB
Line 
1/*
2 * Copyright (c) 2009 Martin Decky
3 * Copyright (c) 2009 Jiri Svoboda
4 * All rights reserved.
5 *
6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions
8 * are met:
9 *
10 * - Redistributions of source code must retain the above copyright
11 * notice, this list of conditions and the following disclaimer.
12 * - Redistributions in binary form must reproduce the above copyright
13 * notice, this list of conditions and the following disclaimer in the
14 * documentation and/or other materials provided with the distribution.
15 * - The name of the author may not be used to endorse or promote products
16 * derived from this software without specific prior written permission.
17 *
18 * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
19 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
20 * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
21 * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
22 * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
23 * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
24 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
25 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
26 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
27 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
28 */
29
30/** @addtogroup ns
31 * @{
32 */
33
34#include <adt/hash_table.h>
35#include <async.h>
36#include <stdbool.h>
37#include <errno.h>
38#include <assert.h>
39#include <macros.h>
40#include <stdio.h>
41#include <stdlib.h>
42#include <types/task.h>
43#include "task.h"
44#include "ns.h"
45
46/** Task hash table item. */
47typedef struct {
48 ht_link_t link;
49
50 task_id_t id; /**< Task ID. */
51 bool finished; /**< Task is done. */
52 bool have_rval; /**< Task returned a value. */
53 int retval; /**< The return value. */
54} hashed_task_t;
55
56static size_t task_key_hash(const void *key)
57{
58 const task_id_t *tid = key;
59 return *tid;
60}
61
62static size_t task_hash(const ht_link_t *item)
63{
64 hashed_task_t *ht = hash_table_get_inst(item, hashed_task_t, link);
65 return ht->id;
66}
67
68static bool task_key_equal(const void *key, size_t hash, const ht_link_t *item)
69{
70 const task_id_t *tid = key;
71 hashed_task_t *ht = hash_table_get_inst(item, hashed_task_t, link);
72 return ht->id == *tid;
73}
74
75/** Perform actions after removal of item from the hash table. */
76static void task_remove(ht_link_t *item)
77{
78 free(hash_table_get_inst(item, hashed_task_t, link));
79}
80
81/** Operations for task hash table. */
82static const hash_table_ops_t task_hash_table_ops = {
83 .hash = task_hash,
84 .key_hash = task_key_hash,
85 .key_equal = task_key_equal,
86 .equal = NULL,
87 .remove_callback = task_remove
88};
89
90/** Task hash table structure. */
91static hash_table_t task_hash_table;
92
93typedef struct {
94 ht_link_t link;
95 sysarg_t label; /**< Incoming phone label. */
96 task_id_t id; /**< Task ID. */
97} p2i_entry_t;
98
99/* label-to-id hash table operations */
100
101static size_t p2i_key_hash(const void *key)
102{
103 const sysarg_t *label = key;
104 return *label;
105}
106
107static size_t p2i_hash(const ht_link_t *item)
108{
109 p2i_entry_t *entry = hash_table_get_inst(item, p2i_entry_t, link);
110 return entry->label;
111}
112
113static bool p2i_key_equal(const void *key, size_t hash, const ht_link_t *item)
114{
115 const sysarg_t *label = key;
116 p2i_entry_t *entry = hash_table_get_inst(item, p2i_entry_t, link);
117
118 return (*label == entry->label);
119}
120
121/** Perform actions after removal of item from the hash table.
122 *
123 * @param item Item that was removed from the hash table.
124 *
125 */
126static void p2i_remove(ht_link_t *item)
127{
128 assert(item);
129 free(hash_table_get_inst(item, p2i_entry_t, link));
130}
131
132/** Operations for task hash table. */
133static const hash_table_ops_t p2i_ops = {
134 .hash = p2i_hash,
135 .key_hash = p2i_key_hash,
136 .key_equal = p2i_key_equal,
137 .equal = NULL,
138 .remove_callback = p2i_remove
139};
140
141/** Map phone label to task ID */
142static hash_table_t phone_to_id;
143
144/** Pending task wait structure. */
145typedef struct {
146 link_t link;
147 task_id_t id; /**< Task ID */
148 ipc_call_t call; /**< Call waiting for the connection */
149} pending_wait_t;
150
151static list_t pending_wait;
152
153errno_t task_init(void)
154{
155 if (!hash_table_create(&task_hash_table, 0, 0, &task_hash_table_ops)) {
156 printf(NAME ": No memory available for tasks\n");
157 return ENOMEM;
158 }
159
160 if (!hash_table_create(&phone_to_id, 0, 0, &p2i_ops)) {
161 printf(NAME ": No memory available for tasks\n");
162 return ENOMEM;
163 }
164
165 list_initialize(&pending_wait);
166 return EOK;
167}
168
169/** Process pending wait requests */
170void process_pending_wait(void)
171{
172 task_exit_t texit;
173
174loop:
175 list_foreach(pending_wait, link, pending_wait_t, pr) {
176 ht_link_t *link = hash_table_find(&task_hash_table, &pr->id);
177 if (!link)
178 continue;
179
180 hashed_task_t *ht = hash_table_get_inst(link, hashed_task_t, link);
181 if (!ht->finished)
182 continue;
183
184 texit = ht->have_rval ? TASK_EXIT_NORMAL :
185 TASK_EXIT_UNEXPECTED;
186 async_answer_2(&pr->call, EOK, texit, ht->retval);
187
188 list_remove(&pr->link);
189 free(pr);
190 goto loop;
191 }
192}
193
194void wait_for_task(task_id_t id, ipc_call_t *call)
195{
196 ht_link_t *link = hash_table_find(&task_hash_table, &id);
197 hashed_task_t *ht = (link != NULL) ?
198 hash_table_get_inst(link, hashed_task_t, link) : NULL;
199
200 if (ht == NULL) {
201 /* No such task exists. */
202 async_answer_0(call, ENOENT);
203 return;
204 }
205
206 if (ht->finished) {
207 task_exit_t texit = ht->have_rval ? TASK_EXIT_NORMAL :
208 TASK_EXIT_UNEXPECTED;
209 async_answer_2(call, EOK, texit, ht->retval);
210 return;
211 }
212
213 /* Add to pending list */
214 pending_wait_t *pr =
215 (pending_wait_t *) malloc(sizeof(pending_wait_t));
216 if (!pr) {
217 async_answer_0(call, ENOMEM);
218 return;
219 }
220
221 link_initialize(&pr->link);
222 pr->id = id;
223 pr->call = *call;
224 list_append(&pr->link, &pending_wait);
225}
226
227errno_t ns_task_id_intro(ipc_call_t *call)
228{
229 task_id_t id = MERGE_LOUP32(ipc_get_arg1(call), ipc_get_arg2(call));
230
231 ht_link_t *link = hash_table_find(&phone_to_id, &call->request_label);
232 if (link != NULL)
233 return EEXIST;
234
235 p2i_entry_t *entry = (p2i_entry_t *) malloc(sizeof(p2i_entry_t));
236 if (entry == NULL)
237 return ENOMEM;
238
239 hashed_task_t *ht = (hashed_task_t *) malloc(sizeof(hashed_task_t));
240 if (ht == NULL) {
241 free(entry);
242 return ENOMEM;
243 }
244
245 /*
246 * Insert into the phone-to-id map.
247 */
248
249 assert(call->request_label);
250 entry->label = call->request_label;
251 entry->id = id;
252 hash_table_insert(&phone_to_id, &entry->link);
253
254 /*
255 * Insert into the main table.
256 */
257
258 ht->id = id;
259 ht->finished = false;
260 ht->have_rval = false;
261 ht->retval = -1;
262 hash_table_insert(&task_hash_table, &ht->link);
263
264 return EOK;
265}
266
267static errno_t get_id_by_phone(sysarg_t label, task_id_t *id)
268{
269 assert(label);
270 ht_link_t *link = hash_table_find(&phone_to_id, &label);
271 if (link == NULL)
272 return ENOENT;
273
274 p2i_entry_t *entry = hash_table_get_inst(link, p2i_entry_t, link);
275 *id = entry->id;
276
277 return EOK;
278}
279
280errno_t ns_task_retval(ipc_call_t *call)
281{
282 task_id_t id = call->task_id;
283
284 ht_link_t *link = hash_table_find(&task_hash_table, &id);
285 hashed_task_t *ht = (link != NULL) ?
286 hash_table_get_inst(link, hashed_task_t, link) : NULL;
287
288 if ((ht == NULL) || (ht->finished))
289 return EINVAL;
290
291 ht->finished = true;
292 ht->have_rval = true;
293 ht->retval = ipc_get_arg1(call);
294
295 process_pending_wait();
296
297 return EOK;
298}
299
300errno_t ns_task_disconnect(ipc_call_t *call)
301{
302 task_id_t id;
303 errno_t rc = get_id_by_phone(call->request_label, &id);
304 if (rc != EOK)
305 return rc;
306
307 /* Delete from phone-to-id map. */
308 hash_table_remove(&phone_to_id, &call->request_label);
309
310 /* Mark task as finished. */
311 ht_link_t *link = hash_table_find(&task_hash_table, &id);
312 if (link == NULL)
313 return EOK;
314
315 hashed_task_t *ht = hash_table_get_inst(link, hashed_task_t, link);
316
317 ht->finished = true;
318
319 process_pending_wait();
320 hash_table_remove(&task_hash_table, &id);
321
322 return EOK;
323}
324
325/**
326 * @}
327 */
Note: See TracBrowser for help on using the repository browser.